Skip to content

Conversation

@kaovilai
Copy link
Member

@kaovilai kaovilai commented Oct 24, 2024

Why the changes were made

Add a new reconcile test to e2e that checks velero pod runs with legacy-aws image WITHOUT b/r tests.

cp #1568

How to test the changes made

ci works

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kaovilai kaovilai changed the title Add legacy-aws default plugin reconcile e2e test. (#1568) oadp-1.4: Add legacy-aws default plugin reconcile e2e test. (#1568) Oct 24, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2024
@kaovilai kaovilai marked this pull request as ready for review October 24, 2024 18:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2024
@shubham-pampattiwar
Copy link
Member

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11ab518 and 2 for PR HEAD b046c18 in total

9 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11ab518 and 2 for PR HEAD b046c18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11ab518 and 2 for PR HEAD b046c18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11ab518 and 2 for PR HEAD b046c18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11ab518 and 2 for PR HEAD b046c18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11ab518 and 2 for PR HEAD b046c18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11ab518 and 2 for PR HEAD b046c18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11ab518 and 2 for PR HEAD b046c18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11ab518 and 2 for PR HEAD b046c18 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 11ab518 and 2 for PR HEAD b046c18 in total

@kaovilai
Copy link
Member Author

/override ci/prow/4.17-e2e-test-kubevirt-aws

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2024

@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.17-e2e-test-kubevirt-aws

In response to this:

/override ci/prow/4.17-e2e-test-kubevirt-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d7cb573 into openshift:oadp-1.4 Oct 25, 2024
21 of 22 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2024

@kaovilai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.18-dev-preview-e2e-test-aws b046c18 link false /test 4.18-dev-preview-e2e-test-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kaovilai kaovilai changed the title oadp-1.4: Add legacy-aws default plugin reconcile e2e test. (#1568) OADP-5106 oadp-1.4: Add legacy-aws default plugin reconcile e2e test. (#1568) Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants