Adding profile support for registry #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakraj1997
commented
Nov 8, 2021
deepakraj1997
force-pushed
the
registry-profile-support
branch
from
540f1e6 to
e45dfb6
Compare
deepakraj1997
changed the title
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
==========================================
+ Coverage 41.48% 41.51% +0.03%
==========================================
Files 9 9
Lines 1849 1869 +20
==========================================
+ Hits 767 776 +9
- Misses 1033 1040 +7
- Partials 49 53 +4
Continue to review full report at Codecov.
|
deepakraj1997
changed the title
deepakraj1997
requested review from
kaovilai and
shubham-pampattiwar
and removed request for
jwmatthews
deepakraj1997
force-pushed
the
registry-profile-support
branch
from
a281009 to
59b9c0d
Compare
shubham-pampattiwar
requested changes
Nov 9, 2021
Member
shubham-pampattiwar
left a comment
shubham-pampattiwar
left a comment
There was a problem hiding this comment.
@deepakraj1997 Thank you for the PR. Overall changes look great ! Just added some suggestions.
Contributor
Author
|
/retest |
Contributor
Author
|
@shubham-pampattiwar thanks for the review. I have made the requested changes. Do review when u have time. Thanks! |
shubham-pampattiwar
approved these changes
Nov 12, 2021
Member
shubham-pampattiwar
left a comment
shubham-pampattiwar
left a comment
There was a problem hiding this comment.
Just added a couple of nits. Apart from that LGTM ! Thank you !
dymurray
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #435