Correct upstream API References property casing, bump velero docs version #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using psuedo version to include datamover features property. https://pkg.go.dev/github.com/openshift/oadp-operator@v0.0.0-20220722142130-a02487302a02/api/v1alpha1#Features Do this to get psuedo version of latest master commit ``` go get -d github.com/openshift/oadp-operator/api@master go: github.com/openshift/oadp-operator/api@master: github.com/openshift/oadp-operator/api@v0.0.0-20220722142130-a02487302a02: invalid version: missing github.com/openshift/oadp-operator/api/go.mod at revision a024873 ``` Closes openshift#770 openshift#768
kaovilai
changed the title
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
- Coverage 36.96% 34.22% -2.75%
==========================================
Files 16 16
Lines 3219 2840 -379
==========================================
- Hits 1190 972 -218
+ Misses 1926 1778 -148
+ Partials 103 90 -13
Continue to review full report at Codecov.
|
kaovilai
changed the title
RichardHoch
reviewed
Jul 26, 2022
RichardHoch
reviewed
Jul 26, 2022
kaovilai
changed the title
RichardHoch
reviewed
Jul 27, 2022
sseago
approved these changes
Jul 27, 2022
Member
Author
|
switching to v0.0.0-20220727202820-c5f87df8fafd for links |
shubham-pampattiwar
approved these changes
Aug 1, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects API references property fields casing to match what user would type into dpa spec.
Hyperlink to types on pkg.go.dev
Using pseudo version pkg.go.dev to include datamover features property.
https://pkg.go.dev/github.com/openshift/oadp-operator@v0.0.0-20220722142130-a02487302a02/api/v1alpha1#Features
May follow up by replacing pseudo-version with tagged version 1.1.0
This PR is accurate as of a024873
Do this to get psuedo version of latest master commit
Closes #770 #768