Bug 1886873: fix ceph cluster delete ordering #855
Conversation
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
rook ceph requires that the deletion request for the cephCluster should come before the delete request for the other ceph resources. Not doing so can result in some of the ceph resources being stuck in deletion phase forever. Deleting the cephCluster first also helps in the cases where the CephCluster has failed to install. Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
In the reconciler, we considered a pending uninstall operation as an error. It resulted in slower reconciliation because of exponential backoff. To avoid the exponential backoff, we need to return the request with the requeueAfter value set. See: kubernetes-sigs/controller-runtime#617 Signed-off-by: Raghavendra Talur <raghavendra.talur@gmail.com>
|
@raghavendra-talur: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle Bug 1886873: fix ceph cluster delete ordering |
openshift-ci-robot
changed the title
openshift-ci-robot
added
the
bugzilla/severity-high
|
@raghavendra-talur: This pull request references Bugzilla bug 1886873, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/test ocs-operator-ci |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jarrpa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1886873, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jarrpa The tests are failing due to what looks like a test infra error |
|
/bugzilla refresh |
|
@raghavendra-talur: This pull request references Bugzilla bug 1886873, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| github.com/prometheus/client_golang v1.7.1 | ||
| github.com/prometheus/client_model v0.2.0 | ||
| github.com/rook/rook v1.4.3-0.20200901124914-0b665e6e3315 | ||
| github.com/rook/rook v1.4.6 |
There was a problem hiding this comment.
Is this used in the downstream builds? v1.4.6 has diverged a bit from what we're using downstream. Some fixes have been backported to the 1.4 branch upstream, but not to the downstream 4.6 branch. OCS should really be referencing the downstream rook branch under github.com/openshift/rook, but it's really a separate topic than for this PR.
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1886873, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1886873, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
crombus
added
bugzilla/valid-bug
|
/retest |
|
@raghavendra-talur: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@raghavendra-talur: All pull requests linked via external trackers have merged: Bugzilla bug 1886873 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
This is a backport of #849 and #850 .
Manually created, I reran the
make deps-updateandmake gen-latest-csvcommands because I wasn't sure if we can cherrypick the generated changes. The result looks identical though.