Skip to content

Conversation

@huffmanca
Copy link
Contributor

Updated the storage-admin permissions so that it may view pods. This permission is necessary, as when running oc describe pvc we list the pods mounting the PVCs.

This PR resolves BZ-1727266.

This is for OS 4.x.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 24, 2019
@huffmanca
Copy link
Contributor Author

/retest

@childsb
Copy link

childsb commented Jul 26, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2019
@childsb
Copy link

childsb commented Jul 26, 2019

/assign @mfojtik
@mfojtik this PR has been reviewed by the storage team but we need someone with permissions to review/merge.

@huffmanca
Copy link
Contributor Author

@mfojtik @deads2k ,

Is it possible to review this one? It's been reviewed by the storage team, and is listed as a blocker for 4.2.

@deads2k
Copy link
Contributor

deads2k commented Aug 12, 2019

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, deads2k, huffmanca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2019
@openshift-merge-robot openshift-merge-robot merged commit 9ff3205 into openshift:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants