Skip to content

Adding the ability to return custom APIObject subclasses from a selector #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2020
Merged

Adding the ability to return custom APIObject subclasses from a selector #83

merged 1 commit into from
Nov 20, 2020

Conversation

@bradmwilliams
Copy link
Contributor

@bradmwilliams bradmwilliams commented Nov 20, 2020

/fixes #82

@bradmwilliams bradmwilliams mentioned this pull request Nov 20, 2020
Closed
@pehala
Copy link
Contributor

pehala commented Nov 20, 2020

This is exactly what I wanted, thanks!

@pehala
Copy link
Contributor

pehala commented Nov 20, 2020

There is a missing update to the object() function.

@bradmwilliams
Copy link
Contributor Author

bradmwilliams commented Nov 20, 2020

Fixed with latest push

@bradmwilliams bradmwilliams merged commit e0e5fdc into openshift:main Nov 20, 2020
@bradmwilliams bradmwilliams deleted the custom_apiobjects branch November 20, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jupierce jupierce Awaiting requested review from jupierce

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow custom subclasses of APIObject for Selector.object() and Selector.objects()

2 participants

@bradmwilliams @pehala