Updating current() logic to handle case insensitive lookup #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradmwilliams
force-pushed
the
current-case-fix
branch
4 times, most recently
from
b7ee783 to
914b1b1
Compare
bradmwilliams
force-pushed
the
current-case-fix
branch
from
baebf5c to
d14f1c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using APIObject.current() to lookup a resource, it was always
using the lowercase qname (kind[.group]/name) to issue a get. This
creates a problem on systems where Uppercase an/or Mixed case name
have been used. The resources are never properly found and any
dependent logic would be impacted. This PR adds the ability to
handle upper|lower|mixed case lookup to the APIObject methods and
preserves existing behaviour. The current() logic will always
lookup objects with lowercase=False.