Skip to content

Conversation

@gabemontero
Copy link
Contributor

…ource

more stringent context requirements (new remote calls added) for download image signatures with new containers/image from recent bump

/assign @bparees
/assign @adambkaplan
@openshift/openshift-team-developer-experience FYI / PTAL

@openshift-ci-robot
Copy link
Contributor

@gabemontero: This pull request references Bugzilla bug 1749557, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1749557: new containers/image requires context with docker reference NewImageS…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2019
@gabemontero
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 5, 2019
@openshift-ci-robot
Copy link
Contributor

@gabemontero: This pull request references Bugzilla bug 1749557, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees
Copy link
Contributor

bparees commented Sep 5, 2019

there's an implication here that we don't have test coverage for image signature import or we would have caught this when the dep bump was done. is it a test that we lost when we lost the integration tests? can we bring it back as part of this PR?

@gabemontero
Copy link
Contributor Author

gabemontero commented Sep 5, 2019

@dmage or @adambkaplan would have to answer the integration test question @bparees ... I know I re-introduced a bunch of integration tests as extended tests late July, but they were build focused.

@gabemontero
Copy link
Contributor Author

One set of passing tests ... the e2e-aws shows green, but had one DC flake with post commit hooks that seems unrelated

also going to run builds and image eco

@gabemontero
Copy link
Contributor Author

/test e2e-aws-builds

@gabemontero
Copy link
Contributor Author

/test e2e-aws-image-ecosystem

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@openshift-merge-robot openshift-merge-robot merged commit 76900b0 into openshift:master Sep 6, 2019
@openshift-ci-robot
Copy link
Contributor

@gabemontero: All pull requests linked via external trackers have merged. Bugzilla bug 1749557 has been moved to the MODIFIED state.

In response to this:

Bug 1749557: new containers/image requires context with docker reference NewImageS…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor

/retitle Bug 1749557: Provide context when obtaining image signatures

@openshift-ci-robot openshift-ci-robot changed the title Bug 1749557: new containers/image requires context with docker reference NewImageS… Bug 1749557: Provide context when obtaining image signatures Sep 6, 2019
@gabemontero gabemontero deleted the panic-containers-image branch September 6, 2019 13:55
stlaz pushed a commit to stlaz/openshift-controller-manager that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants