Skip to content

Conversation

knrc
Copy link

@knrc knrc commented Oct 22, 2018

No description provided.

@knrc
Copy link
Author

knrc commented Oct 22, 2018

@JStickler Can you or Elise please take a look at this?

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2018
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knrc, if you're bumping all the required versions from 3.10 to 3.11, please open a PR against the 3.10 branch to remove the docs from the collection.

@knrc
Copy link
Author

knrc commented Oct 23, 2018

@kalexand-rh The 3.10 content would still be valid for 3.10, do you normally delete whole revisions in documentation?

@kalexand-rh
Copy link
Contributor

@knrc, if 0.2.0 is available on 3.10 and 0.3.0 is only available on 3.11, then we can keep the content in 3.10 and update only the 3.11 branch.

@knrc
Copy link
Author

knrc commented Oct 23, 2018

@kalexand-rh +1, sounds good to me

Copy link
Contributor

@geekspertise geekspertise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through your changes @knrc and they look fine to me.

@JStickler
Copy link
Contributor

@knrc a lot of this is duplicated effort. I've already submitted most of these changes (except for removing 3.10 references, which I'm updating now) in #12578.

@knrc
Copy link
Author

knrc commented Oct 23, 2018

@JStickler I'm confused, I thought we were supposed to be submitting docs for you to review. I didn't even know you had submitted any PR so have definitely not reviewed it.

@JStickler
Copy link
Contributor

@knrc we need to figure out our process I guess.

@knrc
Copy link
Author

knrc commented Oct 24, 2018

Closing this in favour of #12578

@knrc knrc closed this Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-3.11 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants