Skip to content

Conversation

geekspertise
Copy link
Contributor

Updated servicemesh release notes for technology preview 3. @JStickler can you peer review? Already reviewed new content with @knrc and @tvieira.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 23, 2018
@kalexand-rh
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 23, 2018
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small fixes, but other than that, LGTM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a fixed issue, we don't need the workaround anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, we can delete the workaround once the issue moves to the fixed file.

@kalexand-rh
Copy link
Contributor

Per #12589, it sounds like these changes should not be applied to 3.10.

@JStickler
Copy link
Contributor

@kalexand-rh I've asked for clarification on that from @knrc .

@knrc
Copy link

knrc commented Oct 23, 2018

@JStickler @kalexand-rh TP3 (maistra 0.3.0) is based on OCP 3.11.

@vikram-redhat vikram-redhat added this to the Next Release milestone Oct 25, 2018
@JStickler
Copy link
Contributor

@geekspertise, were you going to make updates on this PR so that we can merge it? At the very least, we probably need to rebase against the latest changes to master.

@geekspertise
Copy link
Contributor Author

@JStickler I rebased and force pushed to the servicemesh branch. @kalexand-rh and @vikram-redhat should be good to merge.

@kalexand-rh
Copy link
Contributor

@geekspertise, @JStickler, what's your new release date?

@JStickler
Copy link
Contributor

@kalexand-rh Wednesday 10/31.

@kalexand-rh
Copy link
Contributor

@JStickler, if I merge now, they should go live overnight. Does that sound good to you?

@JStickler
Copy link
Contributor

@kalexand-rh that sounds great. Thanks!

@kalexand-rh
Copy link
Contributor

Great! Merging this PR and #12578

@kalexand-rh kalexand-rh merged commit 7a79ae3 into openshift:master Oct 30, 2018
@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-3.11

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #12712

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-3.11 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants