-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Technology Preview 3 - release notes updates #12596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of small fixes, but other than that, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a fixed issue, we don't need the workaround anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, we can delete the workaround once the issue moves to the fixed file.
dcd9a3c
to
61348af
Compare
Per #12589, it sounds like these changes should not be applied to 3.10. |
@kalexand-rh I've asked for clarification on that from @knrc . |
@JStickler @kalexand-rh TP3 (maistra 0.3.0) is based on OCP 3.11. |
@geekspertise, were you going to make updates on this PR so that we can merge it? At the very least, we probably need to rebase against the latest changes to master. |
61348af
to
ea4de71
Compare
@JStickler I rebased and force pushed to the servicemesh branch. @kalexand-rh and @vikram-redhat should be good to merge. |
@geekspertise, @JStickler, what's your new release date? |
@kalexand-rh Wednesday 10/31. |
@JStickler, if I merge now, they should go live overnight. Does that sound good to you? |
@kalexand-rh that sounds great. Thanks! |
Great! Merging this PR and #12578 |
/cherrypick enterprise-3.11 |
@kalexand-rh: new pull request created: #12712 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Updated servicemesh release notes for technology preview 3. @JStickler can you peer review? Already reviewed new content with @knrc and @tvieira.