-
Notifications
You must be signed in to change notification settings - Fork 1.8k
GH#34497: [OKD] RHCOS image download link instead of FCOS image link #34516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: f5e7094 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/616728a58ae4a000071d63d1 😎 Browse the preview: https://deploy-preview-34516--osdocs.netlify.app |
@binnes PTAL |
LGTM, but in 4.8 I think the procedure is a bit different - URLs are now encoded in installer. See https://github.com/openshift/installer/blob/master/docs/user/overview.md#coreos-bootimages |
@vrutkovs In your comment, are you suggesting this procedure is no longer necessary starting in 4.8? The OKD installer will pull down the correct images? |
Yeah, I think so. OKD installer can both pull images (for IPI) and print the expected artifact URL (for UPI). I think its best be confirmed with installer / CoreOS team (@cgwalters might want to take a look) |
Yep, the same procedure now works for both OCP/RHCOS and OKD/FCOS - it's the same metadata JSON format. |
@cgwalters @vrutkovs What is the effect of Colin's comment to the end user? |
Users now have a more convenient access to the RHCOS artifact location straight from installer, making their UPI installs closer to what IPI creates. |
f2b7a00
to
bd272c2
Compare
bd272c2
to
f5e7094
Compare
/cherrypick enterprise-4.9 |
@mburke5678: new pull request created: #37489 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#34497
Direct internal-only preview: http://file.rdu.redhat.com/mburke/okd-issue-34497/installing/installing_rhv/installing-rhv-user-infra.html#installation-rhv-specifying-rhcos-image-settings_installing-rhv-user-infra