Skip to content

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Jul 13, 2021

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 13, 2021
@netlify
Copy link

netlify bot commented Jul 13, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: f5e7094

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/616728a58ae4a000071d63d1

😎 Browse the preview: https://deploy-preview-34516--osdocs.netlify.app

@mburke5678
Copy link
Contributor Author

@binnes PTAL

@vrutkovs
Copy link
Member

LGTM, but in 4.8 I think the procedure is a bit different - URLs are now encoded in installer. See https://github.com/openshift/installer/blob/master/docs/user/overview.md#coreos-bootimages

@mburke5678
Copy link
Contributor Author

@vrutkovs In your comment, are you suggesting this procedure is no longer necessary starting in 4.8? The OKD installer will pull down the correct images?

@vrutkovs
Copy link
Member

Yeah, I think so. OKD installer can both pull images (for IPI) and print the expected artifact URL (for UPI).

I think its best be confirmed with installer / CoreOS team (@cgwalters might want to take a look)

@cgwalters
Copy link
Member

Yep, the same procedure now works for both OCP/RHCOS and OKD/FCOS - it's the same metadata JSON format.

@mburke5678
Copy link
Contributor Author

@cgwalters @vrutkovs What is the effect of Colin's comment to the end user?

@vrutkovs
Copy link
Member

Users now have a more convenient access to the RHCOS artifact location straight from installer, making their UPI installs closer to what IPI creates.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2021
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@mburke5678: new pull request created: #37489

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants