-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSSMDOC-94: Document OTEL Collector configuration for Tech Preview. #40729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 8c53caf 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61fd81d183faab000895d233 😎 Browse the preview: https://deploy-preview-40729--osdocs.netlify.app |
0661bed
to
cd04137
Compare
@pavolloffay Unless you can use data collection without the distributed tracing platform, I'd put the platform before data collection. And I wouldn't want to change the navigation structure for a technology preview, I'd wait to make that sort of change once we go GA. |
distr_tracing/distr_tracing_install/distr-tracing-deploying-otel.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small nit comments. Otherwise, for overall comments make sure to add the new file attributes that are required: #41331. Along with squashing the commits down to 1. Also, since you did change a filename make sure that you don't need a redirect, if you do the instructions are on the OpenShift Docs Manual :)
/cherry-pick enterprise-4.6 |
/cherry-pick enterprise-4.7 |
/cherry-pick enterprise-4.8 |
/cherry-pick enterprise-4.9 |
/cherry-pick enterprise-4.10 |
@JStickler: new pull request created: #41448 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JStickler: new pull request created: #41449 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JStickler: new pull request created: #41450 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JStickler: new pull request created: #41451 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JStickler: new pull request created: #41452 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR:
Preview is here -> https://deploy-preview-40729--osdocs.netlify.app/openshift-enterprise/latest/distr_tracing/distr_tracing_install/distr-tracing-deploying-otel.html
Eng review - rkukura
QE review - ibalcasa
Peer review -sagidlow