Skip to content

Conversation

JStickler
Copy link
Contributor

@JStickler JStickler commented Jan 18, 2022

This PR:

Eng review - rkukura
QE review - ibalcasa
Peer review -sagidlow

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 18, 2022
@netlify
Copy link

netlify bot commented Jan 18, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 8c53caf

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61fd81d183faab000895d233

😎 Browse the preview: https://deploy-preview-40729--osdocs.netlify.app

@JStickler JStickler force-pushed the OSSMDOC-94 branch 4 times, most recently from 0661bed to cd04137 Compare January 18, 2022 19:49
@JStickler JStickler requested review from jkandasa and rkukura January 18, 2022 20:00
@JStickler
Copy link
Contributor Author

@pavolloffay @iblancasa

@JStickler JStickler added the distributed-tracing Label for all Distributed Tracing PRs label Jan 18, 2022
@pavolloffay
Copy link
Member

I have a question about menu structure for DT. Wouldn't it be easier to navigate and understand the product with the follosing structure:

  • Distributed tracing
    • Release notes
    • Data collection
      • Installation
      • ...
    • Platform
      • Installation
      • ...

Screenshot of Configuring distributed tracing data collection - Distributed tracing installation _ Distributed tracing _ OpenShift Container Platform

@JStickler
Copy link
Contributor Author

@pavolloffay Unless you can use data collection without the distributed tracing platform, I'd put the platform before data collection. And I wouldn't want to change the navigation structure for a technology preview, I'd wait to make that sort of change once we go GA.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 1, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2022
Copy link
Contributor

@sagidlow sagidlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small nit comments. Otherwise, for overall comments make sure to add the new file attributes that are required: #41331. Along with squashing the commits down to 1. Also, since you did change a filename make sure that you don't need a redirect, if you do the instructions are on the OpenShift Docs Manual :)

@sagidlow sagidlow added the peer-review-done Signifies that the peer review team has reviewed this PR label Feb 4, 2022
@JStickler JStickler merged commit e7887bf into openshift:main Feb 4, 2022
@JStickler
Copy link
Contributor Author

/cherry-pick enterprise-4.6

@JStickler
Copy link
Contributor Author

/cherry-pick enterprise-4.7

@JStickler
Copy link
Contributor Author

/cherry-pick enterprise-4.8

@JStickler
Copy link
Contributor Author

/cherry-pick enterprise-4.9

@JStickler
Copy link
Contributor Author

/cherry-pick enterprise-4.10

@openshift-cherrypick-robot

@JStickler: new pull request created: #41448

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #41449

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #41450

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #41451

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@JStickler: new pull request created: #41452

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler JStickler deleted the OSSMDOC-94 branch April 1, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 distributed-tracing Label for all Distributed Tracing PRs peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants