-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Restructured oc-mirror section to include V2 changes #74485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3ea6c34
to
c138ad1
Compare
installing/disconnected_install/installing-mirroring-disconnected-v1.adoc
Outdated
Show resolved
Hide resolved
installing/disconnected_install/installing-mirroring-disconnected-v2.adoc
Outdated
Show resolved
Hide resolved
|
||
The CatalogSource resource is used by Operator Lifecycle Manager (OLM) to retrieve information about the available Operators in the mirror registry. | ||
|
||
Apply the YAML files from the results directory to the cluster by running the following command -> not right and command under it is incorrect No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@subhtk not right and command under it is incorrect ? Hope you missed to add , could you please help check again ?
+ | ||
[source,terminal] | ||
---- | ||
$ oc mirror --config <imageset-Config.yaml> <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@subhtk command should be oc-mirror --config <imageset-config.yaml> file://<oc-mirror workspace path> --v2
do not see --v2
which is important. Also dry-run for v2 explantaion should be a little different. you can read and capture about this from the doc here https://docs.google.com/document/d/1NoRR_pG4W10Q1KiOZ_LaCUuYuAxgVlrv_4BPu-6K-5s/edit#heading=h.vmuf853hmqmh Question no:6
$ cd <oc-mirror workspace path> | ||
---- | ||
|
||
. Review the `mapping.txt` file that was generated. This file contains a list of all images that would be mirrored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be a missing.txt as well that will be generated and you could talk about it as well.
|
||
|
||
["oc-mirror-dry-run-workflow"] | ||
== Use-case scenarios for dry run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@subhtk do not understand this and the above section, which is correct ? Again looks like duplication to me.
[NOTE] | ||
==== | ||
When the image set configuration file contains images that are not present in the oc-mirror cache, these images will be added to the missing.txt file. This file can be found in the dry-run folder. | ||
==== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dry-run folder or the oc-mirror workspace path ? In --v2 are we calling oc-mirror workspace path similar to v1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
When the image set configuration file contains images that are not present in the oc-mirror cache, these images will be added to the missing.txt file. This file can be found in the dry-run folder. | ||
==== | ||
|
||
.Disk to Mirror |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not we have mirror to Disk first and then Disk to mirror ?
|
||
[source,terminal] | ||
---- | ||
$ oc mirror -c <image_set_config.yaml> --workspace <oc-mirror workspace path> docker://<mirror-registry-url> --dry-run --v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have --workspace file://< mirror workspace path>
|
||
[source,terminal] | ||
---- | ||
$ oc mirror -c <image_set_config.yaml> --from <oc-mirror workspace path> docker://<mirror-registry-url> --dry-run --v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to give accurate example format :
oc mirror -c <image_set_config.yaml> --from file://<oc-mirror workspace path> docker://<mirror-registry-url> --dry-run --v2
[source,terminal] | ||
---- | ||
oc-mirror --v2 -c isc-enclave.yaml | ||
--from /local-disk docker://registry.enc1.in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here the command is invalid , should be
oc-mirror --v2 -c isc-enclave.yaml --from file://local-disk docker://registry.enc1.in
mirror: | ||
operators: | ||
- catalog: registry.redhat.io/redhat/redhat-operator-index:v4.10 | ||
- package: elastic-search-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here package is array of objects , must like :
packages:
- name: compliance-operator
mirror: | ||
operators: | ||
- catalog: registry.redhat.io/redhat/redhat-operator-index:v4.10 | ||
- package: elastic-search-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same too, package is array of objects
mirror: | ||
operators: | ||
- catalog: registry.redhat.io/redhat/redhat-operator-index:v4.10 | ||
- package: elastic-search-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same too, package is array of objects
operators: | ||
- catalog: registry.redhat.io/redhat/redhat-operator-index:v4.10 | ||
full: true | ||
- package: elastic-search-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same too, package is array of objects
operators: | ||
- catalog: registry.redhat.io/redhat/redhat-operator-index:v4.10 | ||
full: true | ||
- package: elastic-search-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same too, package is array of objects
|
||
|`mirror.blockedImages` | ||
|The full tag, digest, or pattern of images to block from mirroring. | ||
|Array of strings. For example: `docker.io/library/alpine` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to use correct example for the array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide me the example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@subhtk this pr closed, which is the new one ?
|
||
[source,terminal] | ||
---- | ||
$ oc mirror delete --config delete-image-set-config.yaml --workspace file://<previously-mirrored-work-folder> --v2 --generate docker://<remote-registry> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to give an example for the delete-image-set-config.yaml
Closing due to Merge Conflicts. |
Version(s): 4.16+
Issue: OSDOCS 8197
Link to docs preview: v2
QE review:
Additional information: