OSDOCS 8197: Added delete, dry run, and enclave support functionality for oc-mirror v2 #77289
Conversation
openshift-ci
bot
added
the
size/L
|
🤖 Fri Jun 21 13:45:19 - Prow CI generated the docs preview: https://77289--ocpdocs-pr.netlify.app/ |
subhtk
force-pushed
the
ocm-v2-part3
branch
2 times, most recently
from
33eb6a7 to
fda49cc
Compare
openshift-ci
bot
added
size/XXL
installing/disconnected_install/about-installing-oc-mirror-v2.adoc
Outdated
Show resolved
Hide resolved
subhtk
force-pushed
the
ocm-v2-part3
branch
3 times, most recently
from
a52653a to
a29f590
Compare
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
|
/remove-label peer-review-needed /label peer-review-in-progress |
openshift-ci
bot
added
the
peer-review-in-progress
|
HI @subhtk . Nice work. This PR is alrger than I though. I need to return to release note duties :). I added comments inline. Some changes are needed before I can mark this PR as done. COntact me if you have any Qs. |
|
Thanks @dfitzmau. Really appreciate the review! |
installing/disconnected_install/about-installing-oc-mirror-v2.adoc
Outdated
Show resolved
Hide resolved
| |Description | ||
|
|
||
| |`help` | ||
| |Show help about any subcommand |
| + | ||
| It is recommended to store the file under `$HOME/.config/containers/registries.conf` or `/etc/containers/registries.conf`. | ||
| + | ||
| The TOML format of the file is described in this specification. |
There was a problem hiding this comment.
Maybe group all these paragraphs into one so that step 1 is not overly padded with line breaks?
There was a problem hiding this comment.
Group into one step and add the recommended step as a note?
| [id="prerequisites_oc-mirror-v2_{context}"] | ||
| == Prerequisites | ||
|
|
||
| * You must have a container image registry that supports link:https://docs.docker.com/registry/spec/manifest-v2-2[Docker V2-2] in the location that hosts the {product-title} cluster, such as Red Hat Quay. |
There was a problem hiding this comment.
Red Hat Quay has an attribute = {quay}. Swap throughout?
| [id="oc-mirror-v2-about-dry-run_{context}"] | ||
| = Verifying your selected images for mirroring | ||
|
|
||
| You can use oc-mirror plugin v2 to perform a test run (dry run) that does not actually mirror any images. This allows you to review the list of images that would be mirrored. You can also use a dry run to catch any errors with your image set configuration early. When running a dry run on a mirror-to-disk workflow, the oc-mirror plugin v2 checks if all the images within the image set are available in its cache. Any missing images are listed in the `missing.txt` file. When a dry run is performed before mirroring, both `missing.txt` and `mapping.txt` contain the same list of images. No newline at end of file |
There was a problem hiding this comment.
"This allows you" is an:
Consider:
This means that you can review...
There was a problem hiding this comment.
This enables you to review?
There was a problem hiding this comment.
"Enables" would also be considered anthrophmorphic. Best to state what the "user can do".
installing/disconnected_install/about-installing-oc-mirror-v2.adoc
Outdated
Show resolved
Hide resolved
subhtk
force-pushed
the
ocm-v2-part3
branch
4 times, most recently
from
5cfd782 to
864fcd7
Compare
|
Thanks for your patience and speed on making a few rounds of updates. LGTM /remove-label peer-review-in-progress /label peer-review-done |
openshift-ci
bot
added
peer-review-done
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
bscott-rh
added
merge-review-in-progress
|
@subhtk: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Merge review LGTM. |
bscott-rh
removed
the
merge-review-in-progress
|
/cherrypick enterprise-4.16 |
|
@bscott-rh: new pull request created: #77864 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8 participants
oc-mirror v2 Assembly PR - Part 1- #76917
oc-mirror v2 PR - Part 2- #77247
original PR-#74485
Version(s): 4.16+
Issue: OSDOCS 8197
Link to docs preview: https://77289--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/disconnected_install/about-installing-oc-mirror-v2.html
QE review:
Additional information: