Skip to content

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Nov 5, 2024

Version(s):
4.14

Issue:
OSDOCS-12510

Link to docs preview:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2024

@dfitzmau: This pull request references OSDOCS-12510 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2024

@dfitzmau: This pull request references OSDOCS-12510 which is a valid jira issue.

In response to this:

Version(s):
4.14

Issue:
OSDOCS-12510

Link to docs preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OSDOCS-12510 branch 3 times, most recently from cd8af3a to 53477c8 Compare November 5, 2024 17:06
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 5, 2024

🤖 Thu Nov 07 10:52:34 - Prow CI generated the docs preview:

https://84485--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2024

@dfitzmau: This pull request references OSDOCS-12510 which is a valid jira issue.

In response to this:

Version(s):
4.14

Issue:
OSDOCS-12510

Link to docs preview:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 6, 2024
@tmalove
Copy link
Contributor

tmalove commented Nov 6, 2024

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 6, 2024
@tmalove
Copy link
Contributor

tmalove commented Nov 6, 2024

/remove-label peer-review-in-progress
/label peer-review-done

I added a couple of comments, otherwise looks good.

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 6, 2024
Copy link

openshift-ci bot commented Nov 7, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau merged commit 86dfd5e into openshift:enterprise-4.14 Nov 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants