Skip to content

Conversation

tmalove
Copy link
Contributor

@tmalove tmalove commented Nov 5, 2024

Version(s):
4.13

Issue:
OSDOCS-12512

Link to docs preview:
4.13.53

QE review:

  • QE has approved this change.
    n/a

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 5, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 5, 2024

🤖 Thu Nov 07 14:12:52 - Prow CI generated the docs preview:

https://84508--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-13-release-notes.html

@tmalove
Copy link
Contributor Author

tmalove commented Nov 6, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 6, 2024
@dfitzmau dfitzmau added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-4.13 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 6, 2024
[id="ocp-4-13-53-bug-fixes"]
==== Bug fixes

* Previously, because of a {gcp-first} change, the Cloud Credential Operator (CCO) becomes degraded. With this release, `CredentialsRequests` is updated to set `skipServiceCheck`, and the CCO is not degraded. (link:https://issues.redhat.com/browse/OCPBUGS-43856[*OCPBUGS-43856*])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I contacted Trevor, the note took a bit of a slightly different angle.

See https://issues.redhat.com/browse/OCPBUGS-43821 and #84485. I'd recommend checking with Trevor.

@dfitzmau dfitzmau added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 6, 2024
@tmalove tmalove force-pushed the OSDOCS-12512 branch 2 times, most recently from 0f05f45 to 43c2738 Compare November 6, 2024 18:34
@tmalove
Copy link
Contributor Author

tmalove commented Nov 6, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 6, 2024
@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 6, 2024
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, the most important ones being those about adding contexts. Let me know when this is addressed and then I can merge!

To update an existing {product-title} 4.13 cluster to this latest release, see xref:../updating/updating-cluster-cli.adoc#updating-cluster-cli[Updating a cluster using the CLI].

// 4.13.53
[id="ocp-4-13-53"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All IDs that are not the top ID of an assembly need to have a context at the end:

Suggested change
[id="ocp-4-13-53"]
[id="ocp-4-13-53_{context}"]

$ oc adm release info 4.13.53 --pullspecs
----

[id="ocp-4-13-53-bug-fixes"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about adding a context


* Previously, upgrading to {product-title} 4.14 triggered service disruptions in applications that set duplicate `Transfer-Encoding` headers. This resulted in rejected responses, including a gateway error, which affected customer service. With this release, cluster administrators can use a procedure to detect applications that send duplicate `Transfer-Encoding` headers before upgrading to {product-title} 4.13. Any issues can be corrected before causing service disruption.. (link:https://issues.redhat.com/browse/OCPBUGS-43095[*OCPBUGS-43095*])

[id="ocp-4-13-53-updating"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about adding a context

[id="ocp-4-13-53-bug-fixes"]
==== Bug fixes

* Previously, the Cloud Credential Operator (CCO) for a cluster installed on {gcp-first} was degraded. {gcp-short} clusters that were not in manual mode thought they needed the `backupdr` permissions. However, in accounts where the `backupdr` API was not enabled, the clusters correctly determined that they did not have those permissions. Manual mode {gcp-short} clusters were not affected. With this release, the `skipServiceCheck` parameter is set to `true` on the `CredentialsRequest` custom resource (CR), so this issue no longer occurs. (link:https://issues.redhat.com/browse/OCPBUGS-43856[*OCPBUGS-43856*])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "thought they needed" is a little anthropomorphic. If you think this would still be accurate, I'd suggest changing the wording to something like this:

Suggested change
* Previously, the Cloud Credential Operator (CCO) for a cluster installed on {gcp-first} was degraded. {gcp-short} clusters that were not in manual mode thought they needed the `backupdr` permissions. However, in accounts where the `backupdr` API was not enabled, the clusters correctly determined that they did not have those permissions. Manual mode {gcp-short} clusters were not affected. With this release, the `skipServiceCheck` parameter is set to `true` on the `CredentialsRequest` custom resource (CR), so this issue no longer occurs. (link:https://issues.redhat.com/browse/OCPBUGS-43856[*OCPBUGS-43856*])
* Previously, the Cloud Credential Operator (CCO) for a cluster installed on {gcp-first} was degraded. {gcp-short} clusters that were not in manual mode incorrectly required `backupdr` permissions. However, in accounts where the `backupdr` API was not enabled, the clusters correctly determined that they did not have those permissions. Manual mode {gcp-short} clusters were not affected. With this release, the `skipServiceCheck` parameter is set to `true` on the `CredentialsRequest` custom resource (CR), so this issue no longer occurs. (link:https://issues.redhat.com/browse/OCPBUGS-43856[*OCPBUGS-43856*])


* Previously, the Cloud Credential Operator (CCO) for a cluster installed on {gcp-first} was degraded. {gcp-short} clusters that were not in manual mode thought they needed the `backupdr` permissions. However, in accounts where the `backupdr` API was not enabled, the clusters correctly determined that they did not have those permissions. Manual mode {gcp-short} clusters were not affected. With this release, the `skipServiceCheck` parameter is set to `true` on the `CredentialsRequest` custom resource (CR), so this issue no longer occurs. (link:https://issues.redhat.com/browse/OCPBUGS-43856[*OCPBUGS-43856*])

* Previously, upgrading to {product-title} 4.14 triggered service disruptions in applications that set duplicate `Transfer-Encoding` headers. This resulted in rejected responses, including a gateway error, which affected customer service. With this release, cluster administrators can use a procedure to detect applications that send duplicate `Transfer-Encoding` headers before upgrading to {product-title} 4.13. Any issues can be corrected before causing service disruption.. (link:https://issues.redhat.com/browse/OCPBUGS-43095[*OCPBUGS-43095*])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update is the preferred term:

Suggested change
* Previously, upgrading to {product-title} 4.14 triggered service disruptions in applications that set duplicate `Transfer-Encoding` headers. This resulted in rejected responses, including a gateway error, which affected customer service. With this release, cluster administrators can use a procedure to detect applications that send duplicate `Transfer-Encoding` headers before upgrading to {product-title} 4.13. Any issues can be corrected before causing service disruption.. (link:https://issues.redhat.com/browse/OCPBUGS-43095[*OCPBUGS-43095*])
* Previously, updating to {product-title} 4.14 triggered service disruptions in applications that set duplicate `Transfer-Encoding` headers. This resulted in rejected responses, including a gateway error, which affected customer service. With this release, cluster administrators can use a procedure to detect applications that send duplicate `Transfer-Encoding` headers before updating to {product-title} 4.13. Any issues can be corrected before causing service disruption.. (link:https://issues.redhat.com/browse/OCPBUGS-43095[*OCPBUGS-43095*])


* Previously, the Cloud Credential Operator (CCO) for a cluster installed on {gcp-first} was degraded. {gcp-short} clusters that were not in manual mode thought they needed the `backupdr` permissions. However, in accounts where the `backupdr` API was not enabled, the clusters correctly determined that they did not have those permissions. Manual mode {gcp-short} clusters were not affected. With this release, the `skipServiceCheck` parameter is set to `true` on the `CredentialsRequest` custom resource (CR), so this issue no longer occurs. (link:https://issues.redhat.com/browse/OCPBUGS-43856[*OCPBUGS-43856*])

* Previously, upgrading to {product-title} 4.14 triggered service disruptions in applications that set duplicate `Transfer-Encoding` headers. This resulted in rejected responses, including a gateway error, which affected customer service. With this release, cluster administrators can use a procedure to detect applications that send duplicate `Transfer-Encoding` headers before upgrading to {product-title} 4.13. Any issues can be corrected before causing service disruption.. (link:https://issues.redhat.com/browse/OCPBUGS-43095[*OCPBUGS-43095*])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra period here:

Suggested change
* Previously, upgrading to {product-title} 4.14 triggered service disruptions in applications that set duplicate `Transfer-Encoding` headers. This resulted in rejected responses, including a gateway error, which affected customer service. With this release, cluster administrators can use a procedure to detect applications that send duplicate `Transfer-Encoding` headers before upgrading to {product-title} 4.13. Any issues can be corrected before causing service disruption.. (link:https://issues.redhat.com/browse/OCPBUGS-43095[*OCPBUGS-43095*])
* Previously, upgrading to {product-title} 4.14 triggered service disruptions in applications that set duplicate `Transfer-Encoding` headers. This resulted in rejected responses, including a gateway error, which affected customer service. With this release, cluster administrators can use a procedure to detect applications that send duplicate `Transfer-Encoding` headers before upgrading to {product-title} 4.13. Any issues can be corrected before causing service disruption. (link:https://issues.redhat.com/browse/OCPBUGS-43095[*OCPBUGS-43095*])

@skopacz1 skopacz1 added this to the Continuous Release milestone Nov 6, 2024
Copy link

openshift-ci bot commented Nov 7, 2024

@tmalove: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes LGTM

@skopacz1 skopacz1 merged commit 72cec7c into openshift:enterprise-4.13 Nov 7, 2024
2 checks passed
@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 7, 2024
@tmalove tmalove deleted the OSDOCS-12512 branch November 12, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants