Skip to content

OSSM-8958: Cluster-wide migration using istio injection label #89324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

OSSM-8958: Cluster-wide migration using istio injection label #89324

merged 1 commit into from
Mar 7, 2025

Conversation

rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Feb 27, 2025 •
edited
Loading

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0

Version(s): Technology Preview

NOTE: The Service Mesh 3.0 program is a TP release for early adopters to provide feedback. Kathryn is aware of this. There is a lot of content in flight. After several PRs get merged we will go back and add xrefs. Many topics to which we need to link are not merged yet.

Issue: https://issues.redhat.com/browse/OSSM-8958

Link to docs preview: https://89324--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/cluster-wide/ossm-migrating-cluster-wide-assembly.html#ossm-migrating-a-cluster-wide-deployment-using-the-istio-injection-label_ossm-migrating-cluster-wide-assembly

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OSSM-8958 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OSSM-8958 which is a valid jira issue.

In response to this:

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0

Version(s): Technology Preview

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 27, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 27, 2025 •
edited
Loading

🤖 Fri Mar 07 08:32:35 - Prow CI generated the docs preview:

https://89324--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/cluster-wide/ossm-migrating-cluster-wide-assembly.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 28, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OSSM-8958 which is a valid jira issue.

In response to this:

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0

Version(s): Technology Preview

Issue: https://issues.redhat.com/browse/OSSM-8958

Link to docs preview: https://89324--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/cluster-wide/ossm-migrating-cluster-wide-assembly.html#ossm-migrating-a-cluster-wide-deployment-using-the-istio-injection-label_ossm-migrating-cluster-wide-assembly

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe rh-tokeefe changed the title OSSM-8958: Cluster-wide migration using istio-injection label OSSM-8958: Cluster-wide migration using istio injection label Feb 28, 2025
FilipB
FilipB suggested changes Feb 28, 2025
View reviewed changes
FilipB
FilipB suggested changes Mar 4, 2025
View reviewed changes
@rh-tokeefe rh-tokeefe changed the title OSSM-8958: Cluster-wide migration using istio injection label [WIP] OSSM-8958: Cluster-wide migration using istio injection label Mar 4, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OSSM-8958 which is a valid jira issue.

In response to this:

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0

Version(s): Technology Preview

NOTE: The Service Mesh 3.0 program is a TP release for early adopters to provide feedback. Kathryn is aware of this. There is a lot of content in flight. After several PRs get merged we will go back and add xrefs. Many topics to which we need to link are not merged yet.

Issue: https://issues.redhat.com/browse/OSSM-8958

Link to docs preview: https://89324--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/cluster-wide/ossm-migrating-cluster-wide-assembly.html#ossm-migrating-a-cluster-wide-deployment-using-the-istio-injection-label_ossm-migrating-cluster-wide-assembly

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 4, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2025 •
edited by openshift-ci bot
Loading

@rh-tokeefe: This pull request references OSSM-8958 which is a valid jira issue.

In response to this:

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0

Version(s): Technology Preview

NOTE: The Service Mesh 3.0 program is a TP release for early adopters to provide feedback. Kathryn is aware of this. There is a lot of content in flight. After several PRs get merged we will go back and add xrefs. Many topics to which we need to link are not merged yet.

Issue: https://issues.redhat.com/browse/OSSM-8958

Link to docs preview: https://89324--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/cluster-wide/ossm-migrating-cluster-wide-assembly.html#ossm-migrating-a-cluster-wide-deployment-using-the-istio-injection-label_ossm-migrating-cluster-wide-assembly

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe rh-tokeefe changed the title [WIP] OSSM-8958: Cluster-wide migration using istio injection label OSSM-8958: Cluster-wide migration using istio injection label Mar 4, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 5, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Mar 5, 2025
xenolinux
xenolinux reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments/suggestions to consider; overall LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 5, 2025
@rh-tokeefe rh-tokeefe force-pushed the OSSM-8958 branch 2 times, most recently from 8377263 to 7c42b88 Compare March 5, 2025 23:03
@rh-tokeefe
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 5, 2025
@agantony agantony removed the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 6, 2025
@agantony
Copy link
Contributor

agantony commented Mar 6, 2025

merge review in progress

agantony
agantony reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@agantony agantony left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighted a couple of style guide issues;overall lgtm!

migrating/cluster-wide/ossm-migrating-cluster-wide-assembly.adoc
Comment on lines +56 to +54
If you are using gateways, you must migrate them before you complete the migration process.

* xref:../../migrating/migrating-gateways/ossm-migrating-gateways-assembly.adoc[Migrating gateways from Service Mesh 2 to Service Mesh 3]
If you are not using gateways, and have verified your cluster-wide migration, create a default revision tag and re-label namespaces.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use the Next steps section to provide detailed instructions to documentation users.

https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#lead-in-link-sentence-style-for-the-link-attribute:~:text=Provide%20links%20to%20resources%20that%20contain%20instructions%20that%20might%20be%20useful%20to%20the%20user%20after%20they%20complete%20a%20module%20or%20assembly.%20Do%20not%20use%20the%20Next%20steps%20section%20to%20provide%20detailed%20instructions%20to%20documentation%20users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the textual information at the end of the module.
https://www.ibm.com/docs/en/ibm-style?topic=format-procedures#ending-the-procedure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I should discuss this with the team after the release. We've done this in a few places, and some of the tasks are already merged.

@agantony
Copy link
Contributor

agantony commented Mar 6, 2025

merge review is completed

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 7, 2025

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@agantony
Copy link
Contributor

agantony commented Mar 7, 2025

https://issues.redhat.com/browse/OSSM-9026 created to track the style guide issues

@agantony agantony merged commit db104c1 into openshift:service-mesh-docs-main Mar 7, 2025
2 checks passed
@agantony
Copy link
Contributor

agantony commented Mar 7, 2025

/cherrypick service-mesh-docs-3.0

@openshift-cherrypick-robot
Copy link

@agantony: new pull request created: #89865

In response to this:

/cherrypick service-mesh-docs-3.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 7, 2025
Merged
@xenolinux xenolinux mentioned this pull request Mar 10, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

@agantony agantony agantony left review comments

+2 more reviewers

@FilipB FilipB FilipB approved these changes

@nrfox nrfox nrfox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@rh-tokeefe @openshift-ci-robot @ocpdocs-previewbot @agantony @openshift-cherrypick-robot @FilipB @nrfox @xenolinux