OSSM-8509: Cluster-wide migration using the Istio revision label with cert manager #89396

rh-tokeefe · 2025-02-28T16:19:33Z

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0

Version(s): Technology Preview

Issue: https://issues.redhat.com/browse/OSSM-8509

Link to docs preview: https://89396--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/cluster-wide/ossm-migrating-cluster-wide-assembly.html#ossm-migrating-a-cluster-wide-deployment-using-the-istio-revision-label-with-cert-manager_ossm-migrating-cluster-wide-assembly

QE review:

QE has approved this change.

Additional information:

openshift-ci-robot · 2025-02-28T16:19:37Z

@rh-tokeefe: This pull request references OSSM-8509 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ocpdocs-previewbot · 2025-02-28T16:29:38Z

🤖 Mon Mar 10 23:50:47 - Prow CI generated the docs preview:

https://89396--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/cluster-wide/ossm-migrating-cluster-wide-assembly.html

openshift-ci-robot · 2025-02-28T17:07:54Z

@rh-tokeefe: This pull request references OSSM-8509 which is a valid jira issue.

In response to this:

Version(s):

Issue: https://issues.redhat.com/browse/OSSM-8509

Link to docs preview: https://89396--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/cluster-wide/ossm-migrating-cluster-wide-assembly.html#ossm-migrating-a-cluster-wide-deployment-using-the-istio-revision-label-with-cert-manager_ossm-migrating-cluster-wide-assembly

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-03-03T22:19:57Z

@rh-tokeefe: This pull request references OSSM-8509 which is a valid jira issue.

In response to this:

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0

Version(s): Technology Preview

Issue: https://issues.redhat.com/browse/OSSM-8509

Link to docs preview: https://89396--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/cluster-wide/ossm-migrating-cluster-wide-assembly.html#ossm-migrating-a-cluster-wide-deployment-using-the-istio-revision-label-with-cert-manager_ossm-migrating-cluster-wide-assembly

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

...sm-migrating-a-cluster-wide-deployment-using-the-istio-revision-label-with-cert-manager.adoc

modules/ossm-migrating-workloads-using-the-istio-revision-label-with-cert-manager.adoc

...sm-migrating-a-cluster-wide-deployment-using-the-istio-revision-label-with-cert-manager.adoc

rh-tokeefe · 2025-03-07T17:19:31Z

/label peer-review-needed

aspauldi · 2025-03-07T17:48:14Z

/label peer-review-in-progress

aspauldi

Hi, Just a few comments here and there. Looks good!

...sm-migrating-a-cluster-wide-deployment-using-the-istio-revision-label-with-cert-manager.adoc

migrating/cluster-wide/ossm-migrating-cluster-wide-assembly.adoc

...sm-migrating-a-cluster-wide-deployment-using-the-istio-revision-label-with-cert-manager.adoc

modules/ossm-migrating-workloads-using-the-istio-revision-label-with-cert-manager.adoc

aspauldi · 2025-03-07T18:52:55Z

modules/ossm-migrating-workloads-using-the-istio-revision-label-with-cert-manager.adoc

+[NOTE]
+====
+Do not remove the `maistra.io/ignore-namespace="true"` label until the 2.6 control plane is uninstalled.
+====


Next steps show up in the preview output but not here. I am puzzled!

@aspauldi the next steps reside in the assembly file, not the module file.

Oh sorry about that!

no worries :)

...sm-migrating-a-cluster-wide-deployment-using-the-istio-revision-label-with-cert-manager.adoc

modules/ossm-migrating-workloads-using-the-istio-revision-label-with-cert-manager.adoc

aspauldi · 2025-03-07T20:55:16Z

Good luck with the release!

rh-tokeefe · 2025-03-07T20:59:22Z

Thank you @aspauldi !

quick question -- do you have to apply a peer review done label?

aspauldi · 2025-03-07T21:02:35Z

I will do that, yes! Thanks. I noticed that I hadn't done it but didn't want to interrupt anything by adding it in.

…

On Fri, Mar 7, 2025 at 4:00 PM rh-tokeefe ***@***.***> wrote: Thank you @aspauldi <https://github.com/aspauldi> ! quick question -- do you have to apply a peer review done label? — Reply to this email directly, view it on GitHub <#89396 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKYEN5QIO7W7M45FZY5NK5D2TICD7AVCNFSM6AAAAABYCVQFI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBXGQ2DMNBUGE> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: rh-tokeefe]*rh-tokeefe* left a comment (openshift/openshift-docs#89396) <#89396 (comment)> Thank you @aspauldi <https://github.com/aspauldi> ! quick question -- do you have to apply a peer review done label? — Reply to this email directly, view it on GitHub <#89396 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKYEN5QIO7W7M45FZY5NK5D2TICD7AVCNFSM6AAAAABYCVQFI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBXGQ2DMNBUGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Audrey Spaulding Senior Technical Writer, OpenShift Virtualization ***@***.*** [image: https://www.redhat.com/] <https://www.redhat.com/>

aspauldi · 2025-03-07T21:02:56Z

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

openshift-ci-robot · 2025-03-10T11:52:55Z

@rh-tokeefe: This pull request references OSSM-8509 which is a valid jira issue.

In response to this:

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main
Cherry pick to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0

Version(s): Technology Preview

Issue: https://issues.redhat.com/browse/OSSM-8509

Link to docs preview: https://89396--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/migrating/cluster-wide/ossm-migrating-cluster-wide-assembly.html#ossm-migrating-a-cluster-wide-deployment-using-the-istio-revision-label-with-cert-manager_ossm-migrating-cluster-wide-assembly

QE review:

QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rh-tokeefe · 2025-03-10T12:22:55Z

/label merge-review-needed

xenolinux

I suggest to apply the same peer and merge review feedback that was provided in #89324 to be consistent since the content is nearly similar.

I added two comments as an example.

Gentle reminder: to squash

xenolinux · 2025-03-10T14:26:37Z

modules/ossm-migrating-workloads-using-the-istio-revision-label-with-cert-manager.adoc

+
+[NOTE]
+====
+Do not remove the `maistra.io/ignore-namespace="true"` label until the 2.6 control plane is uninstalled.


Suggestion to update this note to match https://github.com/openshift/openshift-docs/pull/89324/files#diff-5a5665a58f6ee98d8000a42928f9dbca0b6ba2a5568caaed8a9b7f1cdcbb3e23R112 for the consistency

xenolinux · 2025-03-10T14:27:25Z

modules/ossm-migrating-workloads-using-the-istio-revision-label-with-cert-manager.adoc

+reviews-v3-5c5d764c9b-rrx8w.bookinfo          Kubernetes     SYNCED          SYNCED          SYNCED          SYNCED          NOT SENT     istiod-install-istio-system-866b57d668-6lpcr     1.20.8
+----
+
+The previous output shows that the `productpage-v1` deployment is the only deployment that restarted and was injected with the 3.0 proxy. Even if there are different versions of the proxies, communication between services still works.


Suggestion to update the text to match with https://github.com/openshift/openshift-docs/pull/89324/files#diff-5a5665a58f6ee98d8000a42928f9dbca0b6ba2a5568caaed8a9b7f1cdcbb3e23R106 to be consistent.

broken build

openshift-ci · 2025-03-10T23:51:48Z

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

xenolinux · 2025-03-11T08:08:33Z

/cherrypick service-mesh-docs-3.0

openshift-cherrypick-robot · 2025-03-11T08:09:21Z

@xenolinux: new pull request created: #90044

In response to this:

/cherrypick service-mesh-docs-3.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 28, 2025

openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 28, 2025

rh-tokeefe changed the title ~~OSSM-8509: Cluster-wide migration with cert manager~~ OSSM-8509: Cluster-wide migration using the Istio revision label with cert manager Feb 28, 2025

rh-tokeefe force-pushed the OSSM-8509 branch from 236b725 to 56c237a Compare March 3, 2025 21:53

nrfox reviewed Mar 5, 2025

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2025

rh-tokeefe force-pushed the OSSM-8509 branch from cdfacae to c7aa62d Compare March 6, 2025 18:29

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2025

rh-tokeefe force-pushed the OSSM-8509 branch from 394ee4e to b779141 Compare March 7, 2025 08:55

FilipB suggested changes Mar 7, 2025

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2025

rh-tokeefe force-pushed the OSSM-8509 branch from d69a723 to 4cce6cf Compare March 7, 2025 15:50

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2025

FilipB suggested changes Mar 7, 2025

View reviewed changes

...sm-migrating-a-cluster-wide-deployment-using-the-istio-revision-label-with-cert-manager.adoc Outdated Show resolved Hide resolved

FilipB approved these changes Mar 7, 2025

View reviewed changes

rh-tokeefe force-pushed the OSSM-8509 branch from b94f816 to 79d4998 Compare March 7, 2025 17:18

openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 7, 2025

openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 7, 2025

aspauldi reviewed Mar 7, 2025

View reviewed changes

openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 7, 2025

openshift-ci bot removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 7, 2025

rh-tokeefe force-pushed the OSSM-8509 branch from e6bf212 to ff16ebd Compare March 7, 2025 23:01

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 10, 2025

xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 10, 2025

xenolinux reviewed Mar 10, 2025

View reviewed changes

xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 10, 2025

OSSM-8509: Cluster-wide migration with cert manager

b765b49

broken build

rh-tokeefe force-pushed the OSSM-8509 branch from b9b3204 to b765b49 Compare March 10, 2025 23:30

xenolinux merged commit b6ef0e5 into openshift:service-mesh-docs-main Mar 11, 2025
2 checks passed

openshift-cherrypick-robot mentioned this pull request Mar 11, 2025

[service-mesh-docs-3.0] OSSM-8509: Cluster-wide migration using the Istio revision label with cert manager #90044

Merged

OSSM-8509: Cluster-wide migration using the Istio revision label with cert manager #89396

OSSM-8509: Cluster-wide migration using the Istio revision label with cert manager #89396

Uh oh!

Conversation

rh-tokeefe commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 28, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocpdocs-previewbot commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 28, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 3, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rh-tokeefe commented Mar 7, 2025

Uh oh!

aspauldi commented Mar 7, 2025

Uh oh!

aspauldi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aspauldi commented Mar 7, 2025

Uh oh!

rh-tokeefe commented Mar 7, 2025

Uh oh!

aspauldi commented Mar 7, 2025 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aspauldi commented Mar 7, 2025

Uh oh!

openshift-ci-robot commented Mar 10, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rh-tokeefe commented Mar 10, 2025

Uh oh!

xenolinux left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Mar 10, 2025

Uh oh!

rh-tokeefe commented Feb 28, 2025 •

edited

Loading

openshift-ci-robot commented Feb 28, 2025 •

edited by openshift-ci bot

Loading

ocpdocs-previewbot commented Feb 28, 2025 •

edited

Loading

openshift-ci-robot commented Feb 28, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 3, 2025 •

edited by openshift-ci bot

Loading

aspauldi commented Mar 7, 2025 via email •

edited

Loading

openshift-ci-robot commented Mar 10, 2025 •

edited by openshift-ci bot

Loading

xenolinux left a comment •

edited

Loading