OSDOCS 15446 CMA 2.17.2 Changes from Upstream #96544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/M
mburke5678
commented
Jul 23, 2025
Comment on lines
+149
to
+154
| <13> Optional: Specifies the interval in seconds to check each trigger on. The default is `30`. | ||
| <14> Optional: Specifies whether to scale back the target resource to the original replica count after the scaled object is deleted. The default is `false`, which keeps the replica count as it is when the scaled object is deleted. | ||
| <15> Optional: Specifies a name for the horizontal pod autoscaler. The default is `keda-hpa-{scaled-object-name}`. | ||
| <16> Optional: Specifies a scaling policy to use to control the rate to scale pods up or down, as described in the "Scaling policies" section. | ||
| <17> Specifies the trigger to use as the basis for scaling, as described in the "Understanding the custom metrics autoscaler triggers" section. This example uses {product-title} monitoring. | ||
| <18> Optional: Specifies a trigger authentication or a cluster trigger authentication. For more information, see _Understanding the custom metrics autoscaler trigger authentication_ in the _Additional resources_ section. |
There was a problem hiding this comment.
Merge reviewer These call outs are existing texts. Changed only the number.
|
@jkyros Is this something you can PTAL? |
jkyros
reviewed
Aug 25, 2025
| <17> Optional: Specifies a trigger authentication or a cluster trigger authentication. For more information, see _Understanding the custom metrics autoscaler trigger authentication_ in the _Additional resources_ section. | ||
| <11> Optional: Specifies the number of replicas to fall back to if a scaler fails to get metrics from the source for the number of times defined by the `failureThreshold` parameter. For more information on fallback behavior, see the link:https://keda.sh/docs/latest/reference/scaledobject-spec/#fallback[KEDA documentation]. | ||
| <12> Optional: Specifies the replica count to be used if fall back occurs. Enter one of the following options or omit the parameter: | ||
| * Enter `static` to use the number of replicas specified by the `fallback.replicas` parameter. |
There was a problem hiding this comment.
Do we want to mention somewhere that "static" is the default, since that's what gets used if it's omitted? https://keda.sh/docs/2.17/reference/scaledobject-spec/#static-behavior
|
@mburke5678 looks good, just had one question about the static/default |
openshift-ci
bot
added
lgtm
|
New changes are detected. LGTM label has been removed. |
|
@prozehna Can you PTAL? |
prozehna
reviewed
Aug 29, 2025
| <8> Optional: Specifies the maximum number of replicas when scaling up. The default is `100`. | ||
| <9> Optional: Specifies the minimum number of replicas when scaling down. | ||
| <10> Optional: Specifies the parameters for audit logs. as described in the "Configuring audit logging" section. | ||
| <11> Optional: Specifies the number of replicas to fall back to if a scaler fails to get metrics from the source for the number of times defined by the `failureThreshold` parameter. For more information on fallback behavior, see the link:https://keda.sh/docs/2.7/concepts/scaling-deployments/#fallback[KEDA documentation]. |
There was a problem hiding this comment.
my only nit is to change all instances of 'fall back' to 'fallback'
very nitty indeed
mburke5678
force-pushed
the
podauto-cma-2172-upstream
branch
from
692b3ef to
7c46c55
Compare
mburke5678
added
the
merge-review-needed
dfitzmau
added
merge-review-in-progress
dfitzmau
approved these changes
Sep 2, 2025
mburke5678
force-pushed
the
podauto-cma-2172-upstream
branch
from
7c46c55 to
d5a2ece
Compare
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closed in favor of #99294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY TO MERGE WHEN CUSTOM METRICS AUTOSCALER 2.17.2 RELEASES
https://issues.redhat.com/browse/OSDOCS-15446
Link to docs preview:
Understanding the Prometheus trigger -- Added call-out 11 only. No other changes to text.
Adding a custom metrics autoscaler to a workload -- Added call-out 12 only. No other changes to text (other than to bump the call-out numbers).
QE review: