-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS 15446 CMA 2.17.2 Changes from Upstream #96544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -104,28 +104,29 @@ spec: | |
fallback: <11> | ||
failureThreshold: 3 | ||
replicas: 6 | ||
pollingInterval: 30 <12> | ||
behavior: static <12> | ||
pollingInterval: 30 <13> | ||
advanced: | ||
restoreToOriginalReplicaCount: false <13> | ||
restoreToOriginalReplicaCount: false <14> | ||
horizontalPodAutoscalerConfig: | ||
name: keda-hpa-scale-down <14> | ||
behavior: <15> | ||
name: keda-hpa-scale-down <15> | ||
behavior: <16> | ||
scaleDown: | ||
stabilizationWindowSeconds: 300 | ||
policies: | ||
- type: Percent | ||
value: 100 | ||
periodSeconds: 15 | ||
triggers: | ||
- type: prometheus <16> | ||
- type: prometheus <17> | ||
metadata: | ||
serverAddress: https://thanos-querier.openshift-monitoring.svc.cluster.local:9092 | ||
namespace: kedatest | ||
metricName: http_requests_total | ||
threshold: '5' | ||
query: sum(rate(http_requests_total{job="test-app"}[1m])) | ||
authModes: basic | ||
authenticationRef: <17> | ||
authenticationRef: <18> | ||
name: prom-triggerauthentication | ||
kind: TriggerAuthentication | ||
---- | ||
|
@@ -139,13 +140,18 @@ spec: | |
<8> Optional: Specifies the maximum number of replicas when scaling up. The default is `100`. | ||
<9> Optional: Specifies the minimum number of replicas when scaling down. | ||
<10> Optional: Specifies the parameters for audit logs. as described in the "Configuring audit logging" section. | ||
<11> Optional: Specifies the number of replicas to fall back to if a scaler fails to get metrics from the source for the number of times defined by the `failureThreshold` parameter. For more information on fallback behavior, see the link:https://keda.sh/docs/2.7/concepts/scaling-deployments/#fallback[KEDA documentation]. | ||
<12> Optional: Specifies the interval in seconds to check each trigger on. The default is `30`. | ||
<13> Optional: Specifies whether to scale back the target resource to the original replica count after the scaled object is deleted. The default is `false`, which keeps the replica count as it is when the scaled object is deleted. | ||
<14> Optional: Specifies a name for the horizontal pod autoscaler. The default is `keda-hpa-{scaled-object-name}`. | ||
<15> Optional: Specifies a scaling policy to use to control the rate to scale pods up or down, as described in the "Scaling policies" section. | ||
<16> Specifies the trigger to use as the basis for scaling, as described in the "Understanding the custom metrics autoscaler triggers" section. This example uses {product-title} monitoring. | ||
<17> Optional: Specifies a trigger authentication or a cluster trigger authentication. For more information, see _Understanding the custom metrics autoscaler trigger authentication_ in the _Additional resources_ section. | ||
<11> Optional: Specifies the number of replicas to fall back to if a scaler fails to get metrics from the source for the number of times defined by the `failureThreshold` parameter. For more information on fallback behavior, see the link:https://keda.sh/docs/latest/reference/scaledobject-spec/#fallback[KEDA documentation]. | ||
<12> Optional: Specifies the replica count to be used if a fallback occurs. Enter one of the following options or omit the parameter: | ||
* Enter `static` to use the number of replicas specified by the `fallback.replicas` parameter. This is the default. | ||
* Enter `currentReplicas` to maintain the current number of replicas. | ||
* Enter `currentReplicasIfHigher` to maintain the current number of replicas, if that number is higher than the `fallback.replicas` parameter. If the current number of replicas is lower than the `fallback.replicas` parameter, use the `fallback.replicas` value. | ||
* Enter `currentReplicasIfLower` to maintain the current number of replicas, if that number is lower than the `fallback.replicas` parameter. If the current number of replicas is higher than the `fallback.replicas` parameter, use the `fallback.replicas` value. | ||
<13> Optional: Specifies the interval in seconds to check each trigger on. The default is `30`. | ||
<14> Optional: Specifies whether to scale back the target resource to the original replica count after the scaled object is deleted. The default is `false`, which keeps the replica count as it is when the scaled object is deleted. | ||
<15> Optional: Specifies a name for the horizontal pod autoscaler. The default is `keda-hpa-{scaled-object-name}`. | ||
<16> Optional: Specifies a scaling policy to use to control the rate to scale pods up or down, as described in the "Scaling policies" section. | ||
<17> Specifies the trigger to use as the basis for scaling, as described in the "Understanding the custom metrics autoscaler triggers" section. This example uses {product-title} monitoring. | ||
<18> Optional: Specifies a trigger authentication or a cluster trigger authentication. For more information, see _Understanding the custom metrics autoscaler trigger authentication_ in the _Additional resources_ section. | ||
Comment on lines
+149
to
+154
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Merge reviewer These call outs are existing texts. Changed only the number. |
||
* Enter `TriggerAuthentication` to use a trigger authentication. This is the default. | ||
* Enter `ClusterTriggerAuthentication` to use a cluster trigger authentication. | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my only nit is to change all instances of 'fall back' to 'fallback'
very nitty indeed