Added id to user resource #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified resource inorder to obtain user identifer
|
Would this be a better identifier to include? (I assume rhlogin/email can change) |
|
nice addition! thanks! |
There was a problem hiding this comment.
wondering if we shouldnt rename ID to DEFAULT_CLIENT_ID to avoid confusion?
Maybe we should even move the DEFAULT_CLIENT_ID to IOpenShiftConnection?
There was a problem hiding this comment.
Yeah, I think renaming it and moving it to IOpenShiftConnection makes a lot of sense. It kind of pertains to the connection anyway.
There was a problem hiding this comment.
Do you want me to add that change to the PR?
There was a problem hiding this comment.
yes please since I think that your addition is the trigger to move/rename. ok?
Moved Client ID to IOpenShiftConnection
|
Nice enhancement, thanks! I rebased and added unit- & intergration-tests: #150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified user resource in order to obtain user identifer