Skip to content

[OSJC-124] remove quotes from password stored in configuration #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2014
Merged

[OSJC-124] remove quotes from password stored in configuration #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/openshift/client/configuration/AbstractOpenshiftConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ protected String removeQuotes(String value) {
}

public String getPassword() {
return properties.getProperty(KEY_PASSWORD);
return removeQuotes(properties.getProperty(KEY_PASSWORD));
}

public String getClientId() {
Expand Down
24 changes: 24 additions & 0 deletions src/test/java/com/openshift/internal/client/ConfigurationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,4 +258,28 @@ public void fallsBackToDefaultUrl() throws OpenShiftException, IOException {
assertTrue(configuration.getLibraServer().contains(DefaultConfiguration.LIBRA_SERVER));
assertNull(configuration.getRhlogin());
}

@Test
public void canReadPassword() throws OpenShiftException, IOException {
UserConfigurationFake userConfiguration = new UserConfigurationFake() {

protected void initFile(Writer writer) throws IOException {
writer.append(KEY_PASSWORD).append('=').append("somePassword").append('\n');
}

};
assertEquals("somePassword", userConfiguration.getPassword());
}

@Test
public void canStripQuotesOfPassword() throws OpenShiftException, IOException {
UserConfigurationFake userConfiguration = new UserConfigurationFake() {

protected void initFile(Writer writer) throws IOException {
writer.append(KEY_PASSWORD).append('=').append("'somePassword'").append('\n');
}

};
assertEquals("somePassword", userConfiguration.getPassword());
}
}