[OSJC-125] exclude DHE (SSL) ciphers when supported keys are <= 1024 #159
Conversation
|
Java Client Action Required: Only pull request(s) from ["master"] are handled by the openshift-bot |
|
we miss a system property (to force DHE cipher exclusion) and tests before we can merge this. |
There was a problem hiding this comment.
this seem to change api - should it not be 2.7.0 then ?
|
added comments. I would say the system property should be something like .excludeciphers=yes|no|auto and default is auto that will decided based on the bruteforce detection (which should be cached imo) |
|
we are not excluding all ciphers, we're currently just skipping DHE ciphers. Shouldnt we call it .exclude_dhe_ciphers=yes|no|auto |
|
is it important that it is dhe ciphers? would we introduce another property for excluding other ciphers? actually how about call it .filter_bad_ciphers=yes|no|auto |
|
+1 better naming but somehow opaque on what's being removed? |
adietish
force-pushed
the
OSJC-125
branch
3 times, most recently
from
dd0ac28 to
d3ee8ad
Compare
There was a problem hiding this comment.
does this really need to be public api ?
adietish
force-pushed
the
OSJC-125
branch
4 times, most recently
from
c395e92 to
97012d4
Compare
3 participants
No description provided.