Skip to content

Conversation

adietish
Copy link
Member

@adietish adietish commented Oct 6, 2014

No description provided.

@adietish adietish force-pushed the OSJC-128 branch 2 times, most recently from fd73c18 to 39e20a6 Compare October 6, 2014 17:33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have this default to "openshift.redhat.com" and add default constructor?
We could have it check for the OPENSHIFT_BROKER_HOST enviroment var, something like..

private String serverUrl = System.getenv("OPENSHIFT_BROKER_HOST") != null ? System.getenv("OPENSHIFT_BROKER_HOST") : "openshift.redhat.com";

Maybe useful for the folks using the client from a gear itself.

Also, I think before it checked the express.conf for the server, would we still want to do that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the idea, wasnt going into detail here just to showcase the idea.
OpenShiftConfiguration alread has those default, so +1 for the default constructor doing config#getLibraServer

@adietish adietish force-pushed the OSJC-128 branch 2 times, most recently from 3a5cb74 to ff216ca Compare October 13, 2014 14:07
@adietish
Copy link
Member Author

[merge]

@openshift-bot
Copy link

@openshift-bot
Copy link

Evaluated for javaclient up to 2ec0ec6

@adietish
Copy link
Member Author

[merge]

openshift-bot pushed a commit that referenced this pull request Oct 13, 2014
@openshift-bot openshift-bot merged commit 57f0f44 into openshift:master Oct 13, 2014
@adietish adietish deleted the OSJC-128 branch October 13, 2014 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants