[JBIDE-13891] moved user agent setup from factory to http client

src/main/java/com/openshift/internal/client/httpclient/UrlConnectionHttpClient.java

@@ -76,14 +76,25 @@ public UrlConnectionHttpClient(String username, String password, String userAgen
 			IMediaType requestMediaType, String acceptedMediaType, String version, String authKey, String authIV) {
 		this.username = username;
 		this.password = password;
-		this.userAgent = userAgent;
+		this.userAgent = setupUserAgent(authKey, authIV, userAgent);
 		this.sslChecks = sslChecks;
 		this.requestMediaType = requestMediaType;
 		this.acceptedMediaType = acceptedMediaType;
 		this.authKey = authKey;
 		this.authIV = authIV;
 	}
 
+	private String setupUserAgent(String authKey, String authIV, String userAgent) {
+		if (!StringUtils.isEmpty(authKey)) {
+			if (userAgent == null) {
+				userAgent = "OpenShift";
+			} else if (!userAgent.startsWith("OpenShift")) {
+				userAgent = "OpenShift-" + userAgent;
+			}
+		}
+		return userAgent;
+	}
+
 	public void setAcceptedMediaType(String acceptedMediaType) {
 		this.acceptedMediaType = acceptedMediaType;
 	}

src/main/java/com/openshift/internal/client/httpclient/UrlConnectionHttpClientBuilder.java

@@ -65,13 +65,6 @@ public UrlConnectionHttpClientBuilder setVersion(String version) {
 	}
 
 	public IHttpClient client() {
-		if (authKey != null && authKey.trim().length() > 0) {
-			if (userAgent == null) {
-				userAgent = "OpenShift";
-			} else if (!userAgent.startsWith("OpenShift")) {
-				userAgent = "OpenShift-" + userAgent;
-			}
-		}
 		return new UrlConnectionHttpClient(username, password, userAgent,
 				sslChecks, requestMediaType, acceptedMediaType, version,
 				authKey, authIV);

src/main/java/com/openshift/internal/client/utils/StringUtils.java

@@ -32,7 +32,7 @@ public static String toLowerCase(Enum<?> aEnum) {
 
 	public static boolean isEmpty(String string) {
 		return string == null
-				|| string.isEmpty();
+				|| string.trim().isEmpty();
 	}
 
 }