[OSJC-197] Provide delay to allow time for the process to start before checking if it has exited #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e checking if it has exited
|
[test] |
|
Java Client Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/25/) |
|
[merge] |
|
Java Client Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge-openshift-restclient-java/8/) |
|
Evaluated for javaclient up to 078af7c |
openshift-bot
pushed a commit
that referenced
this pull request
Jul 26, 2015
Merged by openshift-bot
There was a problem hiding this comment.
@jcantrill I seriously doubt that a fixed timeout is the right thing to do. What if trying to launch the process takes longer than the hard coded 1 sec?
IMHO you should have a shared lock which makes sure that testing for the process to be alive only occurrs once the process is launched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.