Skip to content

track library version, and refresh cache on version mismatch #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2019
Merged

track library version, and refresh cache on version mismatch #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions openshift/dynamic/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from kubernetes.client.api_client import ApiClient
from kubernetes.client.rest import ApiException

from openshift import __version__
from openshift.dynamic.exceptions import (
api_exception,
ResourceNotFoundError,
Expand Down Expand Up @@ -110,14 +111,17 @@ def __init__(self, client, cache_file=None):

def __init_cache(self, refresh=False):
if refresh or not os.path.exists(self.__cache_file):
self.__cache = {}
self.__cache = {'library_version': __version__}
refresh = True
else:
try:
with open(self.__cache_file, 'r') as f:
self.__cache = json.load(f, cls=cache_decoder(self))
if self.__cache.get('library_version') != __version__:
# Version mismatch, need to refresh cache
self.invalidate_cache()
except Exception:
self.__init_cache(refresh=True)
self.invalidate_cache()
self._load_server_info()
self.__resources.update(self.parse_api_groups())

Expand Down