Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

We are using upper versions of k8s and ocp and the client version should be compatible with them.

…go v0.0.0-20200326155132-2a6cd50aedd0

We are using upper versions of k8s and ocp and the client version should be compatible with them.
@camilamacedo86 camilamacedo86 changed the title Remove github.com/openshift/client-go => github.com/openshift/client-go v0.0.0-20200326155132-2a6cd50aedd0 NO-ISSUE: Remove github.com/openshift/client-go => github.com/openshift/client-go v0.0.0-20200326155132-2a6cd50aedd0 Nov 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: camilamacedo86
Once this PR has been reviewed and has the lgtm label, please assign grokspawn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 11, 2025
@openshift-ci-robot
Copy link

@camilamacedo86: This pull request explicitly references no jira issue.

In response to this:

We are using upper versions of k8s and ocp and the client version should be compatible with them.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86 camilamacedo86 changed the title NO-ISSUE: Remove github.com/openshift/client-go => github.com/openshift/client-go v0.0.0-20200326155132-2a6cd50aedd0 OPRUN-4250: Remove github.com/openshift/client-go => github.com/openshift/client-go v0.0.0-20200326155132-2a6cd50aedd0 Nov 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 11, 2025

@camilamacedo86: This pull request references OPRUN-4250 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

We are using upper versions of k8s and ocp and the client version should be compatible with them.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@camilamacedo86
Copy link
Contributor Author

Hey folks,

I am trying to ensure that we have it properly updated with the edge and cleaned
Could you please help me out move forward with this one

@tmshort @anik120 @bandrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2025

@camilamacedo86: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmshort
Copy link
Contributor

tmshort commented Nov 11, 2025

openshift/client-go is still a 3.5-year-old version:

github.com/openshift/client-go v0.0.0-20220525160904-9e1acff93e4a // indirect

Shouldn't that be updated?

@camilamacedo86
Copy link
Contributor Author

Hi @tmshort

Because we are concerned in remove those replaces I create one PR only for the removal.
I can update

github.com/openshift/client-go v0.0.0-20220525160904-9e1acff93e4a // indirect

In a follow up. WDYT so that we can evaluate properly what version to use
Latest compatible and hopefully the latest available.

@camilamacedo86
Copy link
Contributor Author

I will create one pr with all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants