Bug 2035859: chore: pull constraint-related changes from api, registry and olm #246

dinhxuanvu · 2022-01-25T02:21:25Z

Fix these BZs:

openshift-ci · 2022-01-25T02:22:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dinhxuanvu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2022-01-25T02:22:11Z

@dinhxuanvu: This pull request references Bugzilla bug 2035859, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2035859: chore: pull constraint-related changes from api, registry and olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu · 2022-01-25T02:22:58Z

/bugzilla refresh

openshift-ci · 2022-01-25T02:23:05Z

@dinhxuanvu: This pull request references Bugzilla bug 2035859, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xzha@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu · 2022-01-25T02:23:28Z

@timflannagan @perdasilva PTAL. Thanks

Xia-Zhao-rh · 2022-01-25T05:16:24Z

/retest

Xia-Zhao-rh · 2022-01-25T05:36:27Z

staging/operator-registry/pkg/registry/types.go

+// Validate will validate constraint type and return error(s)
+func (cc *CelConstraint) Validate() []error {
+	errs := []error{}
+	if cc.Cel == nil {


@dinhxuanvu
If using bellow format, error "The CEL field is missing" will be raised.

dependencies:

type: olm.constraint
value:
any:
constraints:
- message: Package prometheus is needed for...
package:
packageName: prometheus
versionRange: '>=0.27.0'
- gvk:
group: camel.apache.org
kind: Integration
version: v1
message: GVK Integration is needed for
message: All are required for etcd because..

dinhxuanvu · 2022-01-25T06:05:56Z

/hold

…shift#211) The constraint EP uses `failureMessage`, not `message`. This is a mistake that should be corrected. Signed-off-by: Vu Dinh <vudinh@outlook.com> Upstream-repository: api Upstream-commit: 160240770853d11a62b3ff721b3ffed2d8edf06d

…t schema (#2572) The correct field for olm.constraint is `failureMessage` instead of `message` as it is currently in the code. This change is to honor the field name that is specified in the original enhancement. Signed-off-by: Vu Dinh <vudinh@outlook.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 25a7159cf292bb9de7164a4db2c1e9c3e402a489

…shift#901) * fix(render/diff): Support olm.constraint in opm render/diff cmd Currently, the olm.constraint type is ignored and not recognized in render and diff cmd. This commit is to add supoprt for constraint type. Signed-off-by: Vu Dinh <vudinh@outlook.com> * Accept any non-specific dependency as property Clean up test code Signed-off-by: Vu Dinh <vudinh@outlook.com> Upstream-repository: operator-registry Upstream-commit: 4e339285b95dad2e635204ff85826aa6099ee6a3

openshift-ci · 2022-01-27T19:33:50Z

@dinhxuanvu: This pull request references Bugzilla bug 2035859, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (xzha@redhat.com), skipping review request.

In response to this:

Bug 2035859: chore: pull constraint-related changes from api, registry and olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu · 2022-01-27T19:34:17Z

So this PR will contain commits to fix the two listed BZs on opm render and diff only. The validation BZ is not addressed in this PR.

dinhxuanvu · 2022-01-27T20:15:35Z

/unhold

dinhxuanvu · 2022-01-27T21:35:35Z

/retest

dinhxuanvu · 2022-01-27T23:35:36Z

/hold

dinhxuanvu · 2022-01-28T00:16:53Z

/retest

ankitathomas · 2022-01-28T14:34:34Z

/retest

openshift-ci · 2022-01-28T16:18:18Z

@dinhxuanvu: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#246

Bugzilla bug 2035859 has been moved to the MODIFIED state.

In response to this:

Bug 2035859: chore: pull constraint-related changes from api, registry and olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-01-28T16:18:33Z

@dinhxuanvu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-01-28T16:53:25Z

@dinhxuanvu: Bugzilla bug 2035859 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 2035859: chore: pull constraint-related changes from api, registry and olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from anik120 and awgreene January 25, 2022 02:22

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2022

dinhxuanvu changed the title ~~chore: pull constraint-related changes from api, registry and olm~~ Bug 2035859: chore: pull constraint-related changes from api, registry and olm Jan 25, 2022

openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 25, 2022

openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 25, 2022

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 25, 2022

Xia-Zhao-rh reviewed Jan 25, 2022

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2022

dinhxuanvu added 3 commits January 27, 2022 13:47

dinhxuanvu force-pushed the registry-validation branch from c24f7d9 to 0d3db55 Compare January 27, 2022 19:33

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2022

openshift-merge-robot merged commit 0d3db55 into openshift:master Jan 28, 2022

Bug 2035859: chore: pull constraint-related changes from api, registry and olm #246

Bug 2035859: chore: pull constraint-related changes from api, registry and olm #246

Uh oh!

Conversation

dinhxuanvu commented Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jan 25, 2022

Uh oh!

openshift-ci bot commented Jan 25, 2022

Uh oh!

dinhxuanvu commented Jan 25, 2022

Uh oh!

openshift-ci bot commented Jan 25, 2022

Uh oh!

dinhxuanvu commented Jan 25, 2022

Uh oh!

Xia-Zhao-rh commented Jan 25, 2022

Uh oh!

Xia-Zhao-rh Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

dinhxuanvu commented Jan 25, 2022

Uh oh!

openshift-ci bot commented Jan 27, 2022

Uh oh!

dinhxuanvu commented Jan 27, 2022

Uh oh!

dinhxuanvu commented Jan 27, 2022

Uh oh!

dinhxuanvu commented Jan 27, 2022

Uh oh!

dinhxuanvu commented Jan 27, 2022

Uh oh!

dinhxuanvu commented Jan 28, 2022

Uh oh!

ankitathomas commented Jan 28, 2022

Uh oh!

openshift-ci bot commented Jan 28, 2022

Uh oh!

openshift-ci bot commented Jan 28, 2022

Uh oh!

openshift-ci bot commented Jan 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dinhxuanvu commented Jan 25, 2022 •

edited

Loading