Skip to content

Conversation

awgreene
Copy link
Contributor

@awgreene awgreene commented Nov 3, 2022

It's important to note that the changes introduced in this PR differ from the upstream changes due to the size of the backport that would be required to introduce the package changes that were made in 4.10.

Signed-off-by: Ben Luddy bluddy@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: f428918

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

@awgreene: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Prop to 4.10 -- Stop corrupting resolver cache. (#2604)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Ben Luddy <bluddy@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: f428918
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@awgreene awgreene force-pushed the stop-corrupting-cache branch from 2329c5a to 70a91b1 Compare November 3, 2022 18:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@awgreene awgreene changed the title Prop to 4.10 -- Stop corrupting resolver cache. (#2604) Stop corrupting resolver cache. (#2604) Nov 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

@awgreene: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Stop corrupting resolver cache. (#2604)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Contributor Author

awgreene commented Nov 3, 2022

/hold

Need to figure out the correct way to pull these changes in.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2022
@awgreene awgreene closed this Nov 3, 2022
@awgreene awgreene reopened this Nov 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

@awgreene: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Stop corrupting resolver cache. (#2604)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Contributor Author

awgreene commented Nov 3, 2022

For future reference, if you need to backport a change that the openshift-cherry-pick robot cannot cherry-pick, you need to:

  1. Checkout the release branch you wish to backport the change to.
  2. Create a new branch
  3. Cherry-pick the commit you want to backport
  4. Rebase the commit so a merge conflict no longer exists
  5. Create a PR

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2022
@awgreene awgreene marked this pull request as ready for review November 3, 2022 18:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2022
@openshift-ci openshift-ci bot requested review from benluddy and hasbro17 November 3, 2022 18:58
@awgreene awgreene changed the title Stop corrupting resolver cache. (#2604) OCPBUGS-3209: Stop corrupting resolver cache. (#2604) Nov 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

@awgreene: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-3209: Stop corrupting resolver cache. (#2604)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 3, 2022
@openshift-ci-robot
Copy link

@awgreene: This pull request references Jira Issue OCPBUGS-3209, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.9.z) matches configured target version for branch (4.9.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-1087 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-1087 targets the "4.10.z" version, which is one of the valid target versions: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Signed-off-by: Ben Luddy bluddy@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: f428918

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 3, 2022
@openshift-ci-robot
Copy link

@awgreene: This pull request references Jira Issue OCPBUGS-3209, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.9.z) matches configured target version for branch (4.9.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-1087 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-1087 targets the "4.10.z" version, which is one of the valid target versions: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @Xia-Zhao-rh

In response to this:

It's important to note that the changes introduced in this PR differ from the upstream changes due to the size of the backport that would be required to introduce the package changes that were made in 4.10.

Signed-off-by: Ben Luddy bluddy@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: f428918

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

@awgreene: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

OCPBUGS-3209: Stop corrupting resolver cache. (#2604)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from Xia-Zhao-rh November 3, 2022 19:37
@awgreene
Copy link
Contributor Author

awgreene commented Nov 4, 2022

/retest

@awgreene
Copy link
Contributor Author

awgreene commented Nov 5, 2022

/retest

@Xia-Zhao-rh
Copy link

Hi, @awgreene
I test this PR, but the result is failed due to no install plan generated.
test steps:

zhaoxia@xzha-mac BUG-3209 % oc get clusterversion
NAME      VERSION                                                  AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.9.0-0.ci.test-2022-11-07-033454-ci-ln-16phyjt-latest   True        False         8m47s   Cluster version is 4.9.0-0.ci.test-2022-11-07-033454-ci-ln-16phyjt-latest

zhaoxia@xzha-mac BUG-3209 % oc exec catalog-operator-5b45987cf6-ztxl6 -- olm --version
OLM version: 0.18.3
git commit: 1586a3c28483d7594688d5fdf4f4da70a3d5a901

1, create catsrc
zhaoxia@xzha-mac BUG-3209 % cat catsrc.yaml 
apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: datapower
  namespace: openshift-marketplace
spec:
  displayName: Test
  publisher: OLM-QE
  sourceType: grpc
  image: icr.io/cpopen/datapower-operator-catalog:1.6.2
  updateStrategy:
    registryPoll:
      interval: 10m

zhaoxia@xzha-mac BUG-3209 % oc apply -f catsrc.yaml 
catalogsource.operators.coreos.com/datapower created

zhaoxia@xzha-mac BUG-3209 % oc get catsrc -A
NAMESPACE               NAME                  DISPLAY               TYPE   PUBLISHER   AGE
openshift-marketplace   certified-operators   Certified Operators   grpc   Red Hat     32m
openshift-marketplace   community-operators   Community Operators   grpc   Red Hat     32m
openshift-marketplace   datapower             Test                  grpc   OLM-QE      12s
openshift-marketplace   redhat-marketplace    Red Hat Marketplace   grpc   Red Hat     32m
openshift-marketplace   redhat-operators      Red Hat Operators     grpc   Red Hat     32m
zhaoxia@xzha-mac BUG-3209 % oc get packagemanifests| grep datapo
datapower-operator                                   Test                  25s

2, create sub
zhaoxia@xzha-mac BUG-3209 % cat sub.yaml
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
  labels:
    operators.coreos.com/datapower-operator.openshift-operators: ""
  name: datapower-operator
  namespace: openshift-operators
spec:
  channel: v1.6
  installPlanApproval: Manual
  name: datapower-operator
  source: datapower
  sourceNamespace: openshift-marketplace
  startingCSV: datapower-operator.v1.6.0

zhaoxia@xzha-mac BUG-3209 % oc apply -f sub.yaml
subscription.operators.coreos.com/datapower-operator created

zhaoxia@xzha-mac BUG-3209 % oc get sub datapower-operator -n openshift-operators -o yaml
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operators.coreos.com/v1alpha1","kind":"Subscription","metadata":{"annotations":{},"labels":{"operators.coreos.com/datapower-operator.openshift-operators":""},"name":"datapower-operator","namespace":"openshift-operators"},"spec":{"channel":"v1.6","installPlanApproval":"Manual","name":"datapower-operator","source":"datapower","sourceNamespace":"openshift-marketplace","startingCSV":"datapower-operator.v1.6.0"}}
  creationTimestamp: "2022-11-07T04:25:02Z"
  generation: 1
  labels:
    operators.coreos.com/datapower-operator.openshift-operators: ""
  name: datapower-operator
  namespace: openshift-operators
  resourceVersion: "34448"
  uid: 70261c1e-b1be-47ff-a0cc-d2cc1a5804d1
spec:
  channel: v1.6
  installPlanApproval: Manual
  name: datapower-operator
  source: datapower
  sourceNamespace: openshift-marketplace
  startingCSV: datapower-operator.v1.6.0
status:
  catalogHealth:
  - catalogSourceRef:
      apiVersion: operators.coreos.com/v1alpha1
      kind: CatalogSource
      name: certified-operators
      namespace: openshift-marketplace
      resourceVersion: "32794"
      uid: c7e9931b-9b7a-4922-9963-f8de9e46a751
    healthy: true
    lastUpdated: "2022-11-07T04:25:03Z"
  - catalogSourceRef:
      apiVersion: operators.coreos.com/v1alpha1
      kind: CatalogSource
      name: community-operators
      namespace: openshift-marketplace
      resourceVersion: "33308"
      uid: 7afbb3cc-bc6a-4ff2-9fb1-39d1a2f5b254
    healthy: true
    lastUpdated: "2022-11-07T04:25:03Z"
  - catalogSourceRef:
      apiVersion: operators.coreos.com/v1alpha1
      kind: CatalogSource
      name: datapower
      namespace: openshift-marketplace
      resourceVersion: "34260"
      uid: 35017df1-9aa8-41ed-909a-de90c2ac49b0
    healthy: true
    lastUpdated: "2022-11-07T04:25:03Z"
  - catalogSourceRef:
      apiVersion: operators.coreos.com/v1alpha1
      kind: CatalogSource
      name: redhat-marketplace
      namespace: openshift-marketplace
      resourceVersion: "29629"
      uid: ddcf316a-3f57-4f2c-b254-1e94d0203a67
    healthy: true
    lastUpdated: "2022-11-07T04:25:03Z"
  - catalogSourceRef:
      apiVersion: operators.coreos.com/v1alpha1
      kind: CatalogSource
      name: redhat-operators
      namespace: openshift-marketplace
      resourceVersion: "32702"
      uid: 2bdd1d87-7f4a-46be-9688-bf6585841ed5
    healthy: true
    lastUpdated: "2022-11-07T04:25:03Z"
  conditions:
  - lastTransitionTime: "2022-11-07T04:25:03Z"
    message: all available catalogsources are healthy
    reason: AllCatalogSourcesHealthy
    status: "False"
    type: CatalogSourcesUnhealthy
  currentCSV: datapower-operator.v1.6.0
  lastUpdated: "2022-11-07T04:25:03Z"
  state: UpgradePending


there is no installplan been created.
zhaoxia@xzha-mac BUG-3209 % oc get ip -n openshift-operators
No resources found in openshift-operators namespace.

check catalog-operator log

time="2022-11-07T04:25:03Z" level=info msg="error updating subscription status" channel=v1.6 error="Operation cannot be fulfilled on subscriptions.operators.coreos.com \"datapower-operator\": the object has been modified; please apply your changes to the latest version and try again" id=joj6c namespace=openshift-operators pkg=datapower-operator source=datapower sub=datapower-operator
E1107 04:25:03.129960       1 queueinformer_operator.go:290] sync "openshift-operators" failed: error updating Subscription status: Operation cannot be fulfilled on subscriptions.operators.coreos.com "datapower-operator": the object has been modified; please apply your changes to the latest version and try again

I try to install other operators, for exmaple: openshift-jenkins-operator, camel-karavan-operator, all met this issue, no installplan generated.

time="2022-11-07T04:44:36Z" level=warning msg="an error was encountered during reconciliation" error="Operation cannot be fulfilled on subscriptions.operators.coreos.com \"camel-karavan-operator\": the object has been modified; please apply your changes to the latest version and try again" event=update reconciling="*v1alpha1.Subscription" selflink=
E1107 04:44:36.782762       1 queueinformer_operator.go:290] sync {"update" "openshift-operators/camel-karavan-operator"} failed: Operation cannot be fulfilled on subscriptions.operators.coreos.com "camel-karavan-operator": the object has been modified; please apply your changes to the latest version and try again

time="2022-11-07T04:45:38Z" level=info msg="error updating subscription status" channel=alpha error="Operation cannot be fulfilled on subscriptions.operators.coreos.com \"openshift-jenkins-operator\": the object has been modified; please apply your changes to the latest version and try again" id=m3cSz namespace=test-1 pkg=openshift-jenkins-operator source=redhat-operators sub=openshift-jenkins-operator
E1107 04:45:38.975727       1 queueinformer_operator.go:290] sync "test-1" failed: error updating Subscription status: Operation cannot be fulfilled on subscriptions.operators.coreos.com "openshift-jenkins-operator": the object has been modified; please apply your changes to the latest version and try again 

@awgreene
Copy link
Contributor Author

/retest

3 similar comments
@awgreene
Copy link
Contributor Author

/retest

@perdasilva
Copy link
Contributor

/retest

@grokspawn
Copy link
Contributor

/retest

@Xia-Zhao-rh
Copy link

Hi, @awgreene
I test this PR, still failed, no install plan is generated.

zhaoxia@xzha-mac test % oc exec catalog-operator-9fc64d595-8cw55    -- olm --version
OLM version: 0.18.3
git commit: 4b88897bf8dd2844b6ee1865ffeeb6de0fee46aa

zhaoxia@xzha-mac test % oc get sub -n test-1 -o yaml
apiVersion: v1
items:
- apiVersion: operators.coreos.com/v1alpha1
  kind: Subscription
  metadata:
    creationTimestamp: "2023-02-09T02:26:06Z"
    generation: 1
    labels:
      operators.coreos.com/etcd.test-1: ""
    name: etcd
    namespace: test-1
    resourceVersion: "31616"
    uid: ad0b18c7-5e52-4cc9-ba39-5887cd39e651
  spec:
    channel: singlenamespace-alpha
    installPlanApproval: Automatic
    name: etcd
    source: community-operators
    sourceNamespace: openshift-marketplace
    startingCSV: etcdoperator.v0.9.4
....
    conditions:
    - lastTransitionTime: "2023-02-09T02:26:07Z"
      message: all available catalogsources are healthy
      reason: AllCatalogSourcesHealthy
      status: "False"
      type: CatalogSourcesUnhealthy
    currentCSV: etcdoperator.v0.9.4
    lastUpdated: "2023-02-09T02:26:07Z"
    state: UpgradePending

zhaoxia@xzha-mac test % oc get ip
No resources found in test-1 namespace.

zhaoxia@xzha-mac test % oc logs catalog-operator-9fc64d595-8cw55| grep test-1
E0209 02:26:06.790196       1 queueinformer_operator.go:290] sync {"update" "test-1/etcd"} failed: Operation cannot be fulfilled on subscriptions.operators.coreos.com "etcd": the object has been modified; please apply your changes to the latest version and try again
time="2023-02-09T02:26:07Z" level=info msg="error updating subscription status" channel=singlenamespace-alpha error="Operation cannot be fulfilled on subscriptions.operators.coreos.com \"etcd\": the object has been modified; please apply your changes to the latest version and try again" id=sWMqm namespace=test-1 pkg=etcd source=community-operators sub=etcd
E0209 02:26:07.184703       1 queueinformer_operator.go:290] sync "test-1" failed: error updating Subscription status: Operation cannot be fulfilled on subscriptions.operators.coreos.com "etcd": the object has been modified; please apply your changes to the latest version and try again

Please help to check it.

@perdasilva
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2023

@awgreene: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 70a91b1 link true /test e2e-gcp
ci/prow/e2e-aws-olm 70a91b1 link true /test e2e-aws-olm
ci/prow/unit-olm 70a91b1 link true /test unit-olm
ci/prow/e2e-aws-console-olm 70a91b1 link true /test e2e-aws-console-olm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 29, 2023
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 28, 2023
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jul 29, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@awgreene: This pull request references Jira Issue OCPBUGS-3209. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

It's important to note that the changes introduced in this PR differ from the upstream changes due to the size of the backport that would be required to introduce the package changes that were made in 4.10.

Signed-off-by: Ben Luddy bluddy@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: f428918

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants