Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Sep 12, 2025

No description provided.

Signed-off-by: Todd Short <todd.short@me.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2025
@openshift-ci-robot
Copy link

@tmshort: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

/label tide/merge-method-rebase

@openshift-ci openshift-ci bot added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Sep 12, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

/test verify-commits

1 similar comment
@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

/test verify-commits

@grokspawn
Copy link
Contributor

Add another commit to see if it will continue to fail? Anik's PR had 2.
(yes, I can't see how that would make a difference, but the next thing to try is to reproduce the specific commit comments as well)

@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

Add another commit to see if it will continue to fail? Anik's PR had 2. (yes, I can't see how that would make a difference, but the next thing to try is to reproduce the specific commit comments as well)

Will try that next. I wanted to check to see if the tide/merge-method-rebase had an effect, and it doesn't.

Signed-off-by: Todd Short <todd.short@me.com>
@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

/test verify-commits

@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

The verify-commits job is complaining about both the already-committed headlines and the new ones.

@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

/test verify-commits

@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

/remove-label tide/merge-method-rebase

@openshift-ci openshift-ci bot removed the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Sep 12, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

/test verify-commits

1 similar comment
@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

/test verify-commits

@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

/label tide/merge-method-merge

@openshift-ci openshift-ci bot added the tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges. label Sep 12, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

/test verify-commits

1 similar comment
@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

/test verify-commits

@tmshort
Copy link
Contributor Author

tmshort commented Sep 12, 2025

verify-commits is failing as expected...

@tmshort tmshort closed this Sep 12, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

@tmshort: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-commits f654991 link true /test verify-commits

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tmshort tmshort deleted the bad-commit-names branch September 15, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. tide/merge-method-merge Denotes a PR that should use a standard merge by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants