Skip to content

Update to upstream main commit 03fe7de #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 22, 2023
Merged

Update to upstream main commit 03fe7de #8

merged 13 commits into from
Jun 22, 2023

Conversation

grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Jun 21, 2023 •
edited
Loading

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@grokspawn grokspawn force-pushed the upstream-main branch 5 times, most recently from 69fa8c5 to 34b1d03 Compare June 22, 2023 17:59
@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@joelanford
Copy link
Member

/hold

I have some questions.. taking them to slack.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2023
Mikalai Radchuk and others added 12 commits June 22, 2023 14:40
@grokspawn
Removes unnecessary constructor wrapper
c03df7a 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@grokspawn
Makes OLMVariableSource responsible for fetching
3d05d55 
`OLMVariableSource` now contains the client and makes requests
to get available operators.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@joelanford @grokspawn
bump catalogd dependency to v0.3.0
2f48441 
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford @grokspawn
operator_controller_test: ensure we cleanup after each spec
b33b1c1 
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@everettraven @grokspawn
add support for handling plain+v0 bundle types (openshift#242)
6e13403
@grokspawn
Replaces "olm.bundle.path" with a constant
cd2b1c5 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@everettraven @grokspawn
add feature gates infrastructure (openshift#263)
0a9abf8 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@joelanford @grokspawn
bump go version to 1.20 (openshift#271)
a24dac4 
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@grokspawn
Adds lint, tidy and verify make targets
203439f 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@grokspawn
Fixes linting issues
1a4b0db 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@grokspawn
Renames package with underscores
6aabcc8 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@grokspawn
Removes name stuttering
b3055bb 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@grokspawn
UPSTREAM: <carry>: bump downstream go to 1.20
5ae0ac0 
Signed-off-by: Jordan <jordan@nimblewidget.com>
@grokspawn grokspawn changed the title Update to upstream main commit 68f6f98 Update to upstream main commit 03fe7de Jun 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2023

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joelanford
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 22, 2023
@joelanford
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@joelanford
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: grokspawn, joelanford

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joelanford
Copy link
Member

Looks like we're missing an OWNERS file in this repo, which I assume is the reason that my /approve comment didn't work. Manually merging for now.

In a follow-up, we should merge DOWNSTREAM_OWNERS/DOWNSTREAM_OWNERS_ALIASES files and add ourselves to this map: https://github.com/openshift/release/blob/78fbcfc0b2ad90e3ebc16c8bbacceef11448b935/core-services/prow/02_config/_plugins.yaml#L2679

I would suggest we just take upstream's OWNERS file, but (1) they don't currently exist and (2) if and when they do exist, we are trying to encourage external contributors, which would likely cause headaches here.

@joelanford joelanford mentioned this pull request Jun 22, 2023
Closed
@joelanford joelanford merged commit 8aee4c0 into openshift:main Jun 22, 2023
@grokspawn grokspawn deleted the upstream-main branch June 23, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joelanford joelanford

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grokspawn @joelanford @everettraven