Skip to content

Conversation

m1kola
Copy link
Contributor

@m1kola m1kola commented Apr 26, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 26, 2024
@openshift-ci-robot
Copy link

@m1kola: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@m1kola
Copy link
Contributor Author

m1kola commented Apr 26, 2024

Holding for now. Want to discuss if we are ok to just disable admission for 4.16.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2024
@openshift-ci openshift-ci bot requested review from dtfranz and tmshort April 26, 2024 14:33
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1kola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola force-pushed the exclude_ValidatingAdmissionPolicy branch from 461c1c3 to 476c137 Compare April 26, 2024 14:41
@m1kola m1kola changed the title NO-ISSUE: UPSTREAM: <carry>: Disable Validating Admission Policy APIs downstream OPRUN-3291: UPSTREAM: <carry>: Disable Validating Admission Policy APIs downstream Apr 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2024

@m1kola: This pull request references OPRUN-3291 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@m1kola
Copy link
Contributor Author

m1kola commented Apr 26, 2024

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2024

@m1kola: This pull request references OPRUN-3291 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

@m1kola: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@m1kola
Copy link
Contributor Author

m1kola commented Apr 29, 2024

I think this is ready to go in

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3f079c4 into openshift:main Apr 29, 2024
@m1kola m1kola deleted the exclude_ValidatingAdmissionPolicy branch April 29, 2024 14:23
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-olm-operator-controller-container-v4.16.0-202404291547.p0.g3f079c4.assembly.stream.el9 for distgit ose-olm-operator-controller.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants