Skip to content

OPRUN-3291: UPSTREAM: <carry>: Enable Validating Admission Policy APIs downstream #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2024
Merged

OPRUN-3291: UPSTREAM: <carry>: Enable Validating Admission Policy APIs downstream #98

merged 1 commit into from
May 1, 2024

Conversation

m1kola
Copy link
Contributor

@m1kola m1kola commented Apr 30, 2024 •
edited
Loading

  • This reverts commit 3f079c4.
  • Adds new manifests with Validating Admission Policy APIs

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2024 •
edited by openshift-ci bot
Loading

@m1kola: This pull request references OPRUN-3291 which is a valid jira issue.

In response to this:

This reverts commit 3f079c4.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@m1kola
Copy link
Contributor Author

m1kola commented Apr 30, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024
@openshift-ci openshift-ci bot requested review from ankitathomas and oceanc80 April 30, 2024 13:35
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: m1kola

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@m1kola m1kola force-pushed the include_ValidatingAdmissionPolicy branch from ed71327 to d3ddf9b Compare April 30, 2024 15:32
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2024 •
edited by openshift-ci bot
Loading

@m1kola: This pull request references OPRUN-3291 which is a valid jira issue.

In response to this:

  • This reverts commit 3f079c4.
  • Adds new manifests with Validating Admission Policy APIs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

UPSTREAM: <carry>: Enable Validating Admission Policy APIs downstream
71e7ed6 
* This reverts commit 3f079c4.
* Includes Validating Admission Policy manifests

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola force-pushed the include_ValidatingAdmissionPolicy branch from d3ddf9b to 71e7ed6 Compare April 30, 2024 15:36
@m1kola
Copy link
Contributor Author

m1kola commented Apr 30, 2024

/test unit

@m1kola
Copy link
Contributor Author

m1kola commented May 1, 2024

/retest

1 similar comment
@m1kola
Copy link
Contributor Author

m1kola commented May 1, 2024

/retest

@m1kola
Copy link
Contributor Author

m1kola commented May 1, 2024

Want openshift-e2e-aws to pass and it seems like it is not required at the moment. So putting this on hold for now.

/hold

@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 1, 2024
@joelanford
Copy link
Member

/test openshift-e2e-aws

@m1kola
Copy link
Contributor Author

m1kola commented May 1, 2024

All seems to be green. Removing hold.

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 1, 2024

@m1kola: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bd56935 into openshift:main May 1, 2024
@m1kola m1kola deleted the include_ValidatingAdmissionPolicy branch May 1, 2024 21:04
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-olm-operator-controller-container-v4.16.0-202405012344.p0.gbd56935.assembly.stream.el9 for distgit ose-olm-operator-controller.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@joelanford joelanford

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@m1kola @openshift-ci-robot @joelanford @openshift-bot