Bug 1901505: Fixed 'time' type to be Fluent::EventTime #2028

vimalk78 · 2020-11-29T10:24:45Z

Description

changed the datatype of 'time'i from float to Fluent::EventTime
added assert on type in existing test case

/cc @jcantrill @igor-karpukhin
/assign @jcantrill @igor-karpukhin

/cherry-pick not sure

Links

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1901505

openshift-ci-robot · 2020-11-29T10:24:49Z

@vimalk78: This pull request references Bugzilla bug 1901505, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1901505: Fixed 'time' type to be Fluent::EventTime

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vimalk78 · 2020-11-29T10:25:44Z

/bugzilla refresh

openshift-ci-robot · 2020-11-29T10:25:53Z

@vimalk78: This pull request references Bugzilla bug 1901505, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

- changed the datatype of 'time'i from float to Fluent::EventTime - added assert on type in existing test case

vimalk78 · 2020-11-29T15:55:15Z

/retest

jcantrill · 2020-11-29T17:42:07Z

/approve
/lgtm

igor-karpukhin

/lgtm

igor-karpukhin · 2020-11-30T08:53:48Z

fluentd/lib/parser_viaq_host_audit/lib/parser_viaq_host_audit.rb

+
+        if parsed_line.nil?
+          t = Time.now
+          time = Fluent::EventTime.new(t.to_i, t.nsec)


nit: This repeatable line can be moved out of if...else..end scope.

openshift-ci-robot · 2020-11-30T08:54:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igor-karpukhin, jcantrill, vimalk78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-11-30T09:32:51Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-30T12:34:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-30T13:52:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-30T14:18:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-30T14:57:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-30T17:20:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-30T19:18:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

vimalk78 · 2020-12-01T11:50:20Z

/retest

vimalk78 · 2020-12-01T16:37:37Z

/retest

openshift-bot · 2020-12-01T17:24:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-01T17:37:36Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T21:06:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T21:58:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-06T22:24:48Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T01:00:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T01:13:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T03:36:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T05:06:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T05:19:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T05:32:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T05:45:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T05:59:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T06:11:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T07:42:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T07:55:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T09:13:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T09:40:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T13:34:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot · 2020-12-07T15:13:18Z

@vimalk78: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/smoke	`8e381f0`	link	`/test smoke`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vimalk78 · 2020-12-07T16:53:46Z

/retest

openshift-bot · 2020-12-07T17:02:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-07T18:07:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jcantrill · 2020-12-07T19:31:57Z

Manually merging to unblock BZ until we can resolve the smoke test failures. The failure is unrelated to the change

openshift-ci-robot · 2020-12-07T19:32:07Z

@vimalk78: All pull requests linked via external trackers have merged:

openshift/origin-aggregated-logging#2028

Bugzilla bug 1901505 has been moved to the MODIFIED state.

In response to this:

Bug 1901505: Fixed 'time' type to be Fluent::EventTime

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-12-07T19:32:31Z

@cuppett: cannot checkout 4.6: error checking out 4.6: exit status 1. output: error: pathspec '4.6' did not match any file(s) known to git

In response to this:

/cherry-pick 4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vimalk78 · 2020-12-14T16:42:45Z

/cherry-pick 4.6

openshift-cherrypick-robot · 2020-12-14T16:43:02Z

@vimalk78: cannot checkout 4.6: error checking out 4.6: exit status 1. output: error: pathspec '4.6' did not match any file(s) known to git

In response to this:

/cherry-pick 4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vimalk78 · 2020-12-14T16:44:04Z

/cherry-pick release-4.6

openshift-cherrypick-robot · 2020-12-14T16:44:17Z

@vimalk78: new pull request created: #2029

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned igor-karpukhin and jcantrill Nov 29, 2020

openshift-ci-robot requested review from igor-karpukhin and jcantrill November 29, 2020 10:24

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 29, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 29, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 29, 2020

Bug 1901505: Fixed 'time' type to be Fluent::EventTime

8e381f0

- changed the datatype of 'time'i from float to Fluent::EventTime - added assert on type in existing test case

vimalk78 force-pushed the bug-1901505 branch from 903ba29 to 8e381f0 Compare November 29, 2020 10:39

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 29, 2020

igor-karpukhin approved these changes Nov 30, 2020

View reviewed changes

jcantrill merged commit d94950e into openshift:master Dec 7, 2020

openshift-cherrypick-robot mentioned this pull request Dec 14, 2020

[release-4.6] Bug 1907519: Fixed 'time' type to be Fluent::EventTime #2029

Merged

Bug 1901505: Fixed 'time' type to be Fluent::EventTime #2028

Bug 1901505: Fixed 'time' type to be Fluent::EventTime #2028

Uh oh!

Conversation

vimalk78 commented Nov 29, 2020

Description

Links

Uh oh!

openshift-ci-robot commented Nov 29, 2020

Uh oh!

vimalk78 commented Nov 29, 2020

Uh oh!

openshift-ci-robot commented Nov 29, 2020

Uh oh!

vimalk78 commented Nov 29, 2020

Uh oh!

jcantrill commented Nov 29, 2020

Uh oh!

igor-karpukhin left a comment

Choose a reason for hiding this comment

Uh oh!

igor-karpukhin Nov 30, 2020

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Nov 30, 2020

Uh oh!

openshift-bot commented Nov 30, 2020

Uh oh!

openshift-bot commented Nov 30, 2020

Uh oh!

openshift-bot commented Nov 30, 2020

Uh oh!

openshift-bot commented Nov 30, 2020

Uh oh!

openshift-bot commented Nov 30, 2020

Uh oh!

openshift-bot commented Nov 30, 2020

Uh oh!

openshift-bot commented Nov 30, 2020

Uh oh!

vimalk78 commented Dec 1, 2020

Uh oh!

vimalk78 commented Dec 1, 2020

Uh oh!

openshift-bot commented Dec 1, 2020

Uh oh!

openshift-bot commented Dec 1, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 6, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!

openshift-bot commented Dec 7, 2020

Uh oh!