Bug 1396433 - Fluentd pop lots of dump an error event: error_class=NoMethodError error="undefined method `empty?' #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MethodError error="undefined method `empty?' https://bugzilla.redhat.com/show_bug.cgi?id=1396433 Never test a value for `empty?` directly - always use the `isempty` method which can be safely used. Added tests to exercise the code with top level values and nested values that do not have the `empty?` method.
|
[test] |
|
Evaluated for aggregated logging test up to c0217b1 |
|
Your fix and new test cases look good to me. |
|
Aggregated Logging Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-origin-aggregated-logging/972/) (Base Commit: 64dade0) |
|
[merge] |
|
Evaluated for aggregated logging merge up to c0217b1 |
|
Aggregated Logging Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-origin-aggregated-logging/973/) (Base Commit: 64dade0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1396433
Never test a value for
empty?directly - always use theisemptymethod which can be safely used.
Added tests to exercise the code with top level values and nested
values that do not have the
empty?method.