Support volume mount subpaths and read-only flag #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
force-pushed
the
volume-mount-subpaths
branch
from
eecd779 to
c257237
Compare
jwforres
reviewed
Jan 19, 2017
app/views/attach-pvc.html
Outdated
| Read only | ||
| </label> | ||
| <div id="read-only-help" class="help-block"> | ||
| Mount the volume read-only. |
There was a problem hiding this comment.
Mount the volume as read-only.
app/views/attach-pvc.html
Outdated
| spellcheck="false" | ||
| aria-describedby="sub-path-help"> | ||
| <div id="sub-path-help" class="help-block"> | ||
| Optional path within the volume from which the container's volume should |
There was a problem hiding this comment.
Maybe:
Optional path within the volume from which it will be mounted into the container. Defaults to the volume's root.
|
also this needs a rebase |
Show subpath and read-only values for volume mounts. Allow users to set these fields on the add storage page.
spadgett
force-pushed
the
volume-mount-subpaths
branch
from
c257237 to
b8b6ce4
Compare
|
@jwforres thanks, updated |
jwforres
approved these changes
Jan 19, 2017
|
[merge] |
|
Evaluated for origin web console merge up to b8b6ce4 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin web console test up to b8b6ce4 |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/951/) (Base Commit: 4b8b74b) |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/953/) (Base Commit: c298116) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show subpath and read-only values for volume mounts. Allow users to set these fields on the add storage page.