Skip to content

Conversation

@spadgett
Copy link
Member

Follow on to #1171

@spadgett spadgett requested a review from jwforres January 24, 2017 14:05
@jwforres
Copy link
Member

LGTM, can merge if travis passes

@benjaminapetersen
Copy link
Contributor

yay! tests 😄

@spadgett
Copy link
Member Author

[merge]

@spadgett
Copy link
Member Author

Unit tests passed, unrelated flake:

/data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/lib/webdriver/promise.js:1761
      throw error;
      ^

Error: Timed out waiting for the WebDriver server at http://172.18.0.88:34074/wd/hub
    at Error (native)
    at onResponse (/data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/http/util.js:87:11)
    at /data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/http/util.js:42:21
    at /data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/lib/webdriver/http/http.js:96:5
    at ClientRequest.<anonymous> (/data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/http/index.js:145:7)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at Socket.socketErrorListener (_http_client.js:310:9)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
>> /data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/lib/webdriver/promise.js:1761
>>       throw error;
>>       ^
>> 
>> Error: Timed out waiting for the WebDriver server at http://172.18.0.88:34074/wd/hub
>>     at Error (native)
>>     at onResponse (/data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/http/util.js:87:11)
>>     at /data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/http/util.js:42:21
>>     at /data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/lib/webdriver/http/http.js:96:5
>>     at ClientRequest.<anonymous> (/data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/http/index.js:145:7)
>>     at emitOne (events.js:96:13)
>>     at ClientRequest.emit (events.js:188:7)
>>     at Socket.socketErrorListener (_http_client.js:310:9)
>>     at emitOne (events.js:96:13)
>>     at Socket.emit (events.js:188:7)
Fatal error: protractor exited with code: 1�

[merge]

@spadgett
Copy link
Member Author

@jwforres FYI, same merge error as before. I don't think it's related to the new tests.

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to bf9fd0a

@openshift-bot
Copy link

openshift-bot commented Jan 24, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/977/) (Base Commit: 3231986)

@openshift-bot openshift-bot merged commit 361d629 into openshift:master Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants