Skip to content

Don't link to image stream tags that haven't synced yet #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Don't link to image stream tags that haven't synced yet #1202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/views/browse/imagestream.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,10 @@ <h1 class="contains-actions">
</tbody>
<tbody ng-if="(tagsByName | hashSize) > 0">
<tr ng-repeat="tag in tagsByName | orderBy : 'name'">
<td data-title="Tag"><a href="{{imageStream | navigateResourceURL}}/{{tag.name}}">{{tag.name}}</a></td>
<td data-title="Tag">
<a ng-if="tag.status" ng-href="{{imageStream | navigateResourceURL}}/{{tag.name}}">{{tag.name}}</a>
<span ng-if="!tag.status">{{tag.name}}</span>
</td>
<td data-title="From">
<!-- this value can get long when its an ImageStreamImage. Use max width and class truncate to elide some
of the SHA1 for long values. They can still be copied even when elided. -->
Expand Down
5 changes: 4 additions & 1 deletion dist/scripts/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3171,7 +3171,10 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
"</tbody>\n" +
"<tbody ng-if=\"(tagsByName | hashSize) > 0\">\n" +
"<tr ng-repeat=\"tag in tagsByName | orderBy : 'name'\">\n" +
"<td data-title=\"Tag\"><a href=\"{{imageStream | navigateResourceURL}}/{{tag.name}}\">{{tag.name}}</a></td>\n" +
"<td data-title=\"Tag\">\n" +
"<a ng-if=\"tag.status\" ng-href=\"{{imageStream | navigateResourceURL}}/{{tag.name}}\">{{tag.name}}</a>\n" +
"<span ng-if=\"!tag.status\">{{tag.name}}</span>\n" +
"</td>\n" +
"<td data-title=\"From\">\n" +
"\n" +
"<span ng-if=\"!tag.spec.from\"><em>pushed</em></span>\n" +
Expand Down