Issue 1244; Secrets 404 Style #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
making @spadgett reviewer on this one since he did the config map 404 |
|
but at a glance LGTM |
|
@MarkDeMaria Looks good to me, but we need to sweep other types as well. Most of our error pages will look like the screenshot in the issue. |
spadgett
approved these changes
Feb 24, 2017
|
Merging this change, and we can look at the others as follow ons. [merge] |
|
Evaluated for origin web console merge up to 1c3cf9a |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1109/) (Base Commit: 7195b40) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1244 : Switches the Secrets 404 alert to a blank slate style, like that of config maps. @jwforres