Promise-Compliance - create.js #1300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
requested changes
Feb 24, 2017
app/scripts/controllers/create.js
Outdated
| }); | ||
| DataService | ||
| .list("imagestreams", {namespace: "openshift"}, null, { | ||
| errorNotification: false |
There was a problem hiding this comment.
I'd leave errorNotification on. Otherwise you'll need to handle the errors here, but the default error notification from data service should be OK.
MarkDeMaria
force-pushed
the
promisesCreate
branch
3 times, most recently
from
6b2b223 to
c0666a0
Compare
|
@spadgett Changes made |
spadgett
requested changes
Feb 27, 2017
| }) | ||
| .then(function(resp) { | ||
| $scope.openshiftImageStreams = resp.by("metadata.name"); | ||
| }); |
There was a problem hiding this comment.
Data.list("imagestreams", {namespace: "openshift"}).then(function(resp) {
$scope.openshiftImageStreams = resp.by("metadata.name");
});Leave the extra arguments off this request and all of the others below to take the defaults.
MarkDeMaria
force-pushed
the
promisesCreate
branch
from
c0666a0 to
59398d7
Compare
|
@spadgett Extra arguments removed! |
spadgett
approved these changes
Feb 27, 2017
|
[merge] |
spadgett
changed the title
|
Evaluated for origin web console merge up to 59398d7 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1117/) (Base Commit: c38d9de) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #799 - Project Creation
@benjaminapetersen @jwforres