Lock bootstrap-switch to version 3.3.3 #1302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids jQuery conflicts with bootstrap-switch 3.3.4.
|
[test] |
|
Evaluated for origin web console test up to e3bc37d |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1113/) (Base Commit: a05779d) |
|
I'm OK with merging this for now |
Merging to unblock the queue. I'll open a follow on issue to look at removing the dependency. [merge] |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1113/) (Base Commit: a05779d) |
|
Evaluated for origin web console merge up to e3bc37d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids jQuery conflicts with bootstrap-switch 3.3.4.
Fixes #1301
@jwforres Opinion on this change? It might be right to remove the dependency altogether, but this works around the bower conflict.