Bumped angular-patternfly to v4.14.6, moment to v2.19.3, and patternfly from to v3.37.4 #2703
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
dtaylor113
force-pushed
the
apf-version-bump
branch
from
c142b63 to
da2cf21
Compare
dtaylor113
changed the title
|
Since we only use moment on the client-side, the denial of service shouldn't impact the console. /assign @rhamilto Robb, can you take a look? |
app/index.html
Outdated
| <link rel="stylesheet" href="bower_components/kubernetes-container-terminal/dist/container-terminal.css" /> | ||
| <link rel="stylesheet" href="bower_components/registry-image-widgets/dist/image-widgets.css" /> | ||
| <link rel="stylesheet" href="bower_components/layout.attrs/dist/layout.attrs.css" /> | ||
| <link rel="stylesheet" href="bower_components/bootstrap-slider/dist/css/bootstrap-slider.css" /> |
There was a problem hiding this comment.
This vendor CSS isn't necessary as it is included in PatternFly, so add bower_components/bootstrap-slider/dist/css/bootstrap-slider.css to the Gruntfile ignore.
There was a problem hiding this comment.
Fixed, thanks. I'll keep an eye on 'bower_components/bootstrap-slider/dist/bootstrap-slider.js', it shouldn't be included either but waiting for patternfly core version release which includes bootstrap-slider in bower
dtaylor113
force-pushed
the
apf-version-bump
branch
from
da2cf21 to
f76032a
Compare
|
It looks like the ReDoS fix does apply to moment.js, so we need to upgrade. |
dtaylor113
force-pushed
the
apf-version-bump
branch
from
f76032a to
333d313
Compare
dtaylor113
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
HI @rhamilto, I believe I have addressed all of your issues. -thanks |
|
/lgtm |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
5 participants
This PR updates angular-patternfly, moment, and patterfly to latest versions in order to (a) show content through filter panel, and (b) remove
unsafe:javascript.void()from 'Clear Filters' link.Fixes openshift/origin-web-catalog#536
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1533363
Patternfly changes were in wizards, notification drawer, and toast notifications. Visually compared and tested each, no issues detected.
This also addresses a Node Security issue in previous version of
moment: