Fix bugzilla 1545011: cpu input disappears in edit autoscaler if value set to 0 #2802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
lgtm but you are missing a dist file it looks like |
benjaminapetersen
force-pushed
the
bug/1545011/autoscaler-cpu-input-disappears
branch
from
b11397b to
249c5fd
Compare
|
great, thx. yup, there is my |
|
/lgtm |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
benjaminapetersen
deleted the
bug/1545011/autoscaler-cpu-input-disappears
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work to tolerate v2beta1 autoscalers.
0, the input would disappearng-showto a falsy value while editing. It should be set to false by the controller only if it is already falsy && metrics are in use.