Consistently use headline case for labels on resource pages #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We sometimes use headline case and sometimes sentence case and are even inconsistent on the same page. Use headline case for the labels always.
Member
|
[merge] |
|
Evaluated for origin web console merge up to 46f6ff4 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/644/) (Base Commit: 109b880) |
This was referenced Dec 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes use headline case and sometimes sentence case. We're even inconsistent on the same page at times. Use headline case for the labels always.
Patternfly guidelines:
http://www.patternfly.org/styles/terminology-and-wording/
The guidelines don't seem to deal with this case specifically, although for other labels like input labels they say to use headline. Whatever we pick, I'd like to be consistent :)
@jwforres PTAL
@rhamilto CC