Add link to check server connection to error page for api discovery #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@spadgett PTAL |
Member
Author
|
|
spadgett
reviewed
Nov 21, 2016
Member
spadgett
left a comment
spadgett
left a comment
There was a problem hiding this comment.
One small comments, otherwise LGTM
app/views/util/error.html
Outdated
| <div>{{errorDetails}}</div> | ||
| <div ng-if="errorLinks.length"> | ||
| <a ng-repeat-start="link in errorLinks" ng-href="{{link.href}}" target="{{link.target || '_blank'}}">{{link.label}}</a> | ||
| <span ng-repeat-end ng-if="!$last" class="divider">|</span> |
Member
There was a problem hiding this comment.
Should it be class="actions-divider"?
jwforres
force-pushed
the
check-server-conn
branch
from
37df222 to
9cca8ae
Compare
Member
Author
|
@spadgett updated |
spadgett
approved these changes
Nov 21, 2016
Member
|
[merge] |
|
Evaluated for origin web console merge up to 9cca8ae |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin web console test up to 9cca8ae |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/745/) (Base Commit: 843d4ae) |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/749/) (Base Commit: a60cd15) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openshift/origin#4368