Allow multicast for VNID 0 #12839
Merged
Allow multicast for VNID 0 #12839
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@openshift/networking PTAL |
Contributor
|
[merge] |
Contributor
|
Evaluated for origin merge up to 90591fa |
Contributor
|
[Test]ing while waiting on the merge queue |
Contributor
|
Evaluated for origin test up to 90591fa |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13655/) (Base Commit: 2bf65d4) |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13655/) (Base Commit: 1787ac5) (Image: devenv-rhel7_5877) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec for this feature says that VNID 0 should just behave like all other VNIDs with multicast: you can multicast within the VNID, but you don't get the "global" effect like with unicast VNID 0 traffic. @dcbw's original code did this right, but when I added the annotation I changed it because I misremembered what behavior we'd decided on.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1419652