Skip to content

NO-JIRA: ci: re-run failed tests and allow for success on flaky connections #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

NO-JIRA: ci: re-run failed tests and allow for success on flaky connections #1638

merged 1 commit into from
Oct 17, 2024

Conversation

@mike-nguyen
Copy link
Member

kola has a flag to re-run tests and allow for it to pass on re-run. This is useful when there are intermittent network failures that happen that is out of our control.

@mike-nguyen
ci: re-run failed tests and allow for sucess on flaky connections
c17ea86 
kola has a flag to re-run tests and allow for it to pass on re-run.
This is useful when there are intermittent network failures that
happen that is out of our control.
@openshift-ci openshift-ci bot requested review from HuijingHei and jlebon October 16, 2024 20:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
dustymabe
dustymabe approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dustymabe,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mike-nguyen mike-nguyen changed the title ci: re-run failed tests and allow for sucess on flaky connections NO-JIRA: ci: re-run failed tests and allow for sucess on flaky connections Oct 16, 2024
@openshift-ci-robot
Copy link

@mike-nguyen: This pull request explicitly references no jira issue.

In response to this:

kola has a flag to re-run tests and allow for it to pass on re-run. This is useful when there are intermittent network failures that happen that is out of our control.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 16, 2024
@mike-nguyen mike-nguyen changed the title NO-JIRA: ci: re-run failed tests and allow for sucess on flaky connections NO-JIRA: ci: re-run failed tests and allow for success on flaky connections Oct 16, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d4863d5 and 2 for PR HEAD c17ea86 in total

@mike-nguyen
Copy link
Member Author

Failures related to: https://discussion.fedoraproject.org/t/invalid-certificate-trust-chain-for-centos-org/133921

@HuijingHei HuijingHei mentioned this pull request Oct 17, 2024
Merged
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d4863d5 and 2 for PR HEAD c17ea86 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d4863d5 and 2 for PR HEAD c17ea86 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

@mike-nguyen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4573987 into openshift:master Oct 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dustymabe dustymabe dustymabe approved these changes

@HuijingHei HuijingHei Awaiting requested review from HuijingHei

@jlebon jlebon Awaiting requested review from jlebon

Assignees

@dustymabe dustymabe

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mike-nguyen @openshift-ci-robot @dustymabe