Skip to content

Updates to CLI Reference - RHDEVDOCS-1521 #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 23, 2020
Merged

Updates to CLI Reference - RHDEVDOCS-1521 #108

merged 6 commits into from
Mar 23, 2020

Conversation

nkakkar81
Copy link

Following changes have been made as part of this PR:

  1. CLI updates as per OCP Guidelines
  2. Added missing/new commands w.r.t latest Pipelines release
  3. Added examples

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 4, 2020
@nkakkar81
Copy link
Author

@Preeticp - raised a PR for CLI changes. Request you to please review. Thanks

Preeticp
Preeticp reviewed Mar 6, 2020
View reviewed changes
@Preeticp
Copy link
Contributor

Preeticp commented Mar 6, 2020

Looks great.
Some minor things and it is ready to be merged.

@nkakkar81
Copy link
Author

@Preeticp - Have incorporated all comments, except one. Please review

Preeticp
Preeticp reviewed Mar 7, 2020
View reviewed changes
Preeticp
Preeticp reviewed Mar 11, 2020
View reviewed changes
@Preeticp
Copy link
Contributor

@nkakkar81 looks great. Some minor comments and a few suggestions.

@nkakkar81
Copy link
Author

@Preeticp - All comments incorporated. Please review. Thanks

Preeticp
Preeticp reviewed Mar 19, 2020
View reviewed changes
modules/ROOT/pages/assembly_cli-reference.adoc
[id='cli-reference_{context}']
= About Tekton CLI

:context: cli-reference
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to change the title to op-tkn-cli... or do you want to do that in a separate PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do this as part of moving the assembly to OCP

Preeticp
Preeticp reviewed Mar 19, 2020
View reviewed changes
@Preeticp
Copy link
Contributor

@nkakkar81 if you decide to take care of all the ID/context and file name changes in another PR, this LGTM, and I will go ahead and merge this PR.

@nkakkar81
Copy link
Author

@Preeticp - the ID/Context is now aligned with the file names. Please review and merge if you don't have further comments. Thanks!!

Preeticp
Preeticp reviewed Mar 23, 2020
View reviewed changes
modules/ROOT/pages/assembly_cli-reference.adoc Outdated

// CLI Reference
include::ref_cli-reference.adoc[leveloffset=+1]
include::op-tkn-cli-reference.adoc[leveloffset=+1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

op-tkn-reference?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done with the change.

@Preeticp Preeticp merged commit a084938 into openshift:op-0.10-master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Preeticp Preeticp Preeticp left review comments

Assignees

No one assigned

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nkakkar81 @Preeticp @openshift-ci-robot