Skip to content

Conversation

yhontyk
Copy link
Contributor

@yhontyk yhontyk commented Sep 11, 2019

Hi guys!
I am debating right now a few points:

  1. Whether we should have a separate module for CRC.
  2. Should I reword it so it would be clear that CRC is the recommended supported solution for quick deployment of clusters and that Pipelines can be used on any properly set up and running OpenShift cluster.
  3. That VirtualBox line... It is not our product (it is made by Oracle...) but CRC docs do mention it since the commands needs to be run with those flags if the user has VistualBox.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 11, 2019
@Preeticp Preeticp changed the title added-crc-procedure [WIP] added-crc-procedure Sep 12, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2019
@yhontyk
Copy link
Contributor Author

yhontyk commented Sep 23, 2019

@joaedwar this PR has slipped my mind! :D We're good to merge here as for now.

@nebelsprachen nebelsprachen merged commit fc9cd64 into openshift:master Sep 25, 2019
@nebelsprachen nebelsprachen changed the title [WIP] added-crc-procedure Added-crc-procedure Sep 25, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2019
@nebelsprachen nebelsprachen changed the title Added-crc-procedure Added CRC procedure Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants